Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global variables and disable a check #3925

Merged
merged 1 commit into from
Jul 10, 2024
Merged

remove global variables and disable a check #3925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions experimental/Schemes/src/elliptic_surface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,11 @@
end
r = 1
i = 0
dp = typeof(O)[]
while true
i = i+1
@vprint :EllipticSurface 2 "computing $(p^i)-torsion"
global dp = division_points(O, p^i)
dp = division_points(O, p^i)
if length(dp) == r
break
end
Expand Down Expand Up @@ -438,7 +439,7 @@
a = [numerator(a)(t) for a in a]
(a1,a2,a3,a4,a6) = a
ft = y^2 + a1*x*y + a3*y - (x^3 + a2*x^2 + a4*x+a6)
I = IdealSheaf(P, U, [ft])
I = IdealSheaf(P, U, [ft]; check=false)

inc_S = CoveredClosedEmbedding(P, I)
Scov = domain(inc_S) # The ADE singular elliptic K3 surface
Expand Down Expand Up @@ -533,7 +534,7 @@
# no extra singularities in the X = 1 chart
# therefore we just exclude all the singularities visible here
for W in [P[1][2],P[1][5]]
local Ising = I_sing_P(W)
Ising = I_sing_P(W)
if isone(Ising)
push!(refined_charts, W)
continue
Expand Down Expand Up @@ -849,9 +850,10 @@
@req all(is_prime(i) for i in f) "not a vector of prime divisors"
f = copy(f)
O = components(zero_section(S))[1]
local f0

Check warning on line 853 in experimental/Schemes/src/elliptic_surface.jl

View check run for this annotation

Codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L853 

Added line #L853 was not covered by tests
for (i,D) in enumerate(f)
if !isone(O+components(D)[1])
global f0 = D
f0 = D
deleteat!(f,i)
break
end
Expand Down
Loading