preserveAspectRatio

[mattupham]

What is the purpose of the change:

Preserve aspect ratio on chart svg

Linear Task

https://linear.app/osmosis/issue/FE-948/portfolio-update-chart-svg-to-span-full-width

Brief Changelog

Testing and Verifying

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	❌ Failed (Inspect)			Aug 8, 2024 5:42am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2024 5:42am
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2024 5:42am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Aug 8, 2024 5:42am
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2024 5:42am

[coderabbitai]

Walkthrough

The recent updates enhance the chart components by introducing new properties for controlling chart visibility and scaling options. Notably, the showScales property allows users to toggle the visibility of chart scales, while the isChartMinimized state in the PortfolioPage component manages the chart's minimized state. These changes improve interactivity and usability across various portfolio views and historical charts.

Changes

Files	Change Summary
packages/web/components/chart/historical-chart.tsx	Introduced showScales prop to control scale visibility and added preserveAspectRatio="none" to the SVG element.
packages/web/components/chart/light-weight-charts/chart.tsx	Updated defaultOptions and defaultOptionsWithSeries to include comments on scale visibility settings.
packages/web/components/complex/portfolio/assets-overview.tsx	Added isChartMinimized and setIsChartMinimized props for chart visibility control, implemented animations.
packages/web/components/complex/portfolio/historical-chart.tsx	Refactored PortfolioHistoricalChart to use forwardRef, added showScales prop, and adjusted minimized chart height.
packages/web/components/complex/portfolio/portfolio-page.tsx	Introduced state management for isChartMinimized to control chart visibility in PortfolioPage.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PortfolioPage
    participant AssetsOverview
    participant HistoricalChart

    User->>PortfolioPage: Toggle chart visibility
    PortfolioPage->>AssetsOverview: Update isChartMinimized state
    AssetsOverview->>HistoricalChart: Render based on isChartMinimized
    HistoricalChart-->>AssetsOverview: Display minimized or expanded chart
    AssetsOverview-->>User: Show updated chart view

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jonator]

Nice.

Perhaps we could use this as an opportunity to update BG if the BG changes from limitOrders FF are on?

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

packages/web/components/complex/portfolio/assets-overview.tsx (1)

142-142: Consider using optional chaining.

The static analysis tool suggests using optional chaining to simplify code and handle potential undefined values safely.

- {wallet && wallet.isWalletConnected && wallet.address ? (
+ {wallet?.isWalletConnected && wallet.address ? (

- disabled={totalValue && totalValue.toDec().isZero()}
+ disabled={totalValue?.toDec().isZero()}

Also applies to: 207-207

Tools

Biome

[error] 142-142: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)