Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH continuous covariates #163

Merged
merged 13 commits into from
Aug 7, 2023
Merged

ENH continuous covariates #163

merged 13 commits into from
Aug 7, 2023

Conversation

BorisMuzellec
Copy link
Collaborator

@BorisMuzellec BorisMuzellec commented Aug 1, 2023

Reference Issue or PRs

Fixes #100

What does your PR implement? Be specific.

This PR adds support for continuous covariates in PyDESeq2.

More precisely:

  • An optional continuous_factors argument was added to DeseqDataSet and utils.build_design_matrix, in which users may provide a list of design factors that should be considered as continuous / numerical;
  • The contrast handling of DeseqStats was updated to account for continuous factors;
  • Tests were added to compare the results of PyDESeq2 to those of DESeq2 in the presence of continuous factors, on synthetic data.

Copy link
Collaborator

@maikia maikia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @BorisMuzellec

pydeseq2/ds.py Outdated Show resolved Hide resolved
pydeseq2/utils.py Outdated Show resolved Hide resolved
BorisMuzellec and others added 2 commits August 7, 2023 11:45
@BorisMuzellec
Copy link
Collaborator Author

BorisMuzellec commented Aug 7, 2023

Thanks for the review @maikia !

@BorisMuzellec BorisMuzellec merged commit f08abcb into main Aug 7, 2023
8 checks passed
@BorisMuzellec BorisMuzellec deleted the continuous_covariates branch August 7, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-level factors and continuous covariates
2 participants