check relations domains #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use commas for pos column - add satellite adjectives PoS * validation - check that a relation has the correct domain (either synset or wordsense of the appropriate PoS) obs: maybe this is too much to check in the parser phase and we should defer it to validation? (the parser is not so easy to read now) related to #6
odanoburu
commented
Aug 30, 2019
| @@ -1,34 +1,34 @@ | |||
| name lexicographer file text file rdf pos domain description | |||
| antonymOf ! ant wn30/own-pt/schema/antonymOf nvar word Antonym | |||
| antonymOf ! ant wn30/own-pt/schema/antonymOf n,v,a,r word Antonym | |||
There was a problem hiding this comment.
algum problema com essa mudança? imagino que não mas é bom checar rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to @hmuniz for pointing out the lack of this check!
wordsense of the appropriate PoS)
related to #6