New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Arithmetic & Logical ops #39

Merged

dcvz merged 24 commits into dev from api/ops-arithmetic-logical

Apr 22, 2024

Contributor

dcvz commented Apr 20, 2024

No description provided.


          Add arithmetic and logic operators

77faf45

dcvz changed the base branch from main to dev

April 20, 2024 20:36

dcvz added 8 commits

April 20, 2024 22:48


          Fix docs tests

7c6fffb


          Move abs to arithmetic

b67a8db

fmt

bffdf33


          Add sqrt and all_close

9f3223d


          Add missing docs

485a926


          Remaining missing arithmetic

b0cfd5e


          Add last missing logical op

677ab45


          Use impl Into<>

d75ad21

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Show resolved Hide resolved

dcvz added 2 commits

April 21, 2024 14:57


          Safety and checks for add

e7ea60c


          Finish arithmetic

ced4d4e

minghuaw reviewed

View reviewed changes

src/error.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/error.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/error.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

mlx-macros/src/lib.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/utils.rs Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/arithmetic.rs Outdated Show resolved Hide resolved

dcvz added 6 commits

April 22, 2024 11:41


          Add logical safe methods

25aa6db


          Address first set of PR comments

d8080a1


          Add try_close variants

f24752f


          Merge branch 'dev' into api/ops-arithmetic-logical

193ae89

# Conflicts:
#	src/array.rs


          Add missing test cases and methods

dcc30f7


          Add test for reshaping to negative dims

4bc4bb5

dcvz commented

View reviewed changes

src/ops/reduction.rs Outdated Show resolved Hide resolved


          Add tiny comment

18e4824

dcvz mentioned this pull request

feat(tests): integration tests against python mlx #41

Closed

dcvz added 2 commits

April 22, 2024 23:55


          Update DtypeMismatch error

581f670


          add test for reshape with negative dimension other than -1

34ca4aa

minghuaw reviewed

View reviewed changes

src/ops/logical.rs Outdated Show resolved Hide resolved

minghuaw reviewed

View reviewed changes

src/ops/reduction.rs Outdated Show resolved Hide resolved

dcvz and others added 4 commits

April 23, 2024 01:19


          Unify all method

51bab39


          link to swift's broadcasting doc

d40d861


          Merge branch 'api/ops-arithmetic-logical' of https://github.com/oxide…

cdffdaf

…ai/mlx-rs into api/ops-arithmetic-logical


          Fix docs

8620a01

minghuaw approved these changes

View reviewed changes

Collaborator

minghuaw left a comment

I think it's good to go

dcvz merged commit 270a2e5 into dev

3 checks passed

dcvz deleted the api/ops-arithmetic-logical branch

April 22, 2024 23:31

dcvz mentioned this pull request

Tracking issue for migrating to use mlx-c #35

Open

48 tasks

minghuaw added a commit that referenced this pull request


          feat(api): Arithmetic & Logical ops (#39)

5f265f9

Co-authored-by: minghuaw <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet