Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test deployment locally with tmt (from packit branch) #581

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Test deployment locally with tmt (from packit branch) #581

merged 12 commits into from
Sep 16, 2024

Conversation

majamassarini
Copy link
Member

@majamassarini majamassarini commented Jul 1, 2024 •
edited
Loading

To be able to access secrets and test ansible scripts using github secrets in the testing farm github action I need to create a PR from the packit repo itself (and not from a fork).

This is the reason why the PR is duplicated at the moment.

Should fix #562 #563 #564 #565

@majamassarini
Copy link
Member Author

[test]

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/130e80788d3045dc8ce603194e937406

✔️ pre-commit SUCCESS in 1m 44s
❌ deployment-tests RETRY_LIMIT in 1m 35s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/67ef8dfbb5d74c3286365622f9b81142

✔️ pre-commit SUCCESS in 1m 45s
❌ deployment-tests RETRY_LIMIT in 1m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e4c7beb2ae0f4092b8d0a31ba1b795ba

✔️ pre-commit SUCCESS in 1m 40s
❌ deployment-tests RETRY_LIMIT in 1m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c2b65fa6ac444763b2c80fe3546e4d0a

✔️ pre-commit SUCCESS in 1m 37s
❌ deployment-tests RETRY_LIMIT in 1m 17s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3dc0f47e3aac4393a34daf4674cc67d6

✔️ pre-commit SUCCESS in 1m 45s
❌ deployment-tests RETRY_LIMIT in 2m 04s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/939549a711694817aea013a89cc61791

✔️ pre-commit SUCCESS in 1m 51s
❌ deployment-tests RETRY_LIMIT in 1m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/793515f47e19445cb7ab6096e7316889

✔️ pre-commit SUCCESS in 1m 37s
❌ deployment-tests RETRY_LIMIT in 1m 35s

@majamassarini majamassarini force-pushed the tf-openshift-tests branch 5 times, most recently from b232a4c to 385b341 Compare July 2, 2024 12:45
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d2813a1988d54e8180654af15b790d35

✔️ pre-commit SUCCESS in 1m 52s
❌ deployment-tests RETRY_LIMIT in 4m 23s

@majamassarini majamassarini force-pushed the tf-openshift-tests branch 6 times, most recently from b0b87a1 to b6d1528 Compare July 3, 2024 07:32
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3cae622ad8cd4e4095a97e961fbe7e73

✔️ pre-commit SUCCESS in 1m 41s
❌ deployment-tests RETRY_LIMIT in 1m 41s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/961aa796336e4d43b81d937650786a1a

✔️ pre-commit SUCCESS in 1m 37s
❌ deployment-tests RETRY_LIMIT in 1m 37s

@majamassarini
Copy link
Member Author

check

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/508c2a5e73694556bdb8ca10d0489a9d

✔️ pre-commit SUCCESS in 1m 41s
❌ deployment-tests NODE_FAILURE Node request 200-0007574685 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1a101a09e09e4b9fb80bd61c6d1c8919

✔️ pre-commit SUCCESS in 1m 44s
❌ deployment-tests NODE_FAILURE Node request 200-0007574755 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/78eeaea734574953a69c04c4297f2d48

✔️ pre-commit SUCCESS in 1m 38s
❌ deployment-tests NODE_FAILURE Node request 200-0007574829 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c1a1dd07b56145e68ccb8472aab8450a

✔️ pre-commit SUCCESS in 1m 42s
❌ deployment-tests NODE_FAILURE Node request 200-0007574967 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/53865cbbd5bd45268bb399e78e107697

✔️ pre-commit SUCCESS in 1m 43s
❌ deployment-tests NODE_FAILURE Node request 200-0007575226 failed in 0s

majamassarini and others added 2 commits September 13, 2024 09:45
@majamassarini @lbarcziova @mfocko
Improve docs related with testing changes
b7b7804 
Co-authored-by: Laura Barcziová <[email protected]>
Co-authored-by: Matej Focko <[email protected]>
@majamassarini
Deploy github-app-private-key for worker and service
e906d88 
Tokman is no longer used.
The github-app-private-key is now used directly by the service and the workers.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ccdab2c531e04bba803738e6304bc196

✔️ pre-commit SUCCESS in 1m 40s
❌ deployment-tests NODE_FAILURE Node request 200-0007575933 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d3bdaaf9bb3241d684927ad086497cb4

✔️ pre-commit SUCCESS in 1m 36s
❌ deployment-tests NODE_FAILURE Node request 200-0007576015 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4b168a7c3379431881a017e2957e5b28

✔️ pre-commit SUCCESS in 1m 41s
❌ deployment-tests NODE_FAILURE Node request 200-0007576041 failed in 0s

lbarcziova
lbarcziova approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schedule test on Testing Farm / tests (pull_request) Successful in 36m 🥳 🥳 🥳

great job Maja!

as for the Zuul deployment-tests, can we remove them right now or in a follow-up PR? We should then also configure the new check to be required to pass for merging (in the repo settings).

@majamassarini
Do not call deploy test from zuul
9702af0 
Now we are using testing farm for it.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/44558e2f3b924aaba16b540f88b6d31c

✔️ pre-commit SUCCESS in 1m 40s

@majamassarini
Copy link
Member Author

as for the Zuul deployment-tests, can we remove them right now or in a follow-up PR? We should then also configure the new check to be required to pass for merging (in the repo settings).

I have disabled deployment test from zuul.
Regarding the required check I thought @lachmanfrantisek prefers not to use the github testing farm integration, but for me it is ok if we want to enable it.

@lbarcziova
Copy link
Member

@majamassarini I meant just changing the branch protection rules to require tests check to be passing

mfocko
mfocko approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.github/workflows/tf-tests.yml Show resolved Hide resolved
@mfocko
Copy link
Member

mfocko commented Sep 16, 2024

as for the Zuul deployment-tests, can we remove them right now or in a follow-up PR? We should then also configure the new check to be required to pass for merging (in the repo settings).

I have disabled deployment test from zuul. Regarding the required check I thought @lachmanfrantisek prefers not to use the github testing farm integration, but for me it is ok if we want to enable it.

Yes, it is preferred. Though having no (red) CI right now is IMO bit worse, and you have the GH Action ready 🤷 flakey > nothing IMO

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Sep 16, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0e345ffd9df146e5a9cc2b3b99680798

✔️ pre-commit SUCCESS in 1m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d29ce15 into main Sep 16, 2024
5 checks passed
@majamassarini majamassarini mentioned this pull request Sep 16, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@mfocko mfocko mfocko approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majamassarini @mfocko @lbarcziova