Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dialogue / Name / BGM data for new Trainers, remove and replace data for an old Trainer. #107

Merged
merged 6 commits into from
Feb 1, 2025

Conversation

Blitz425
Copy link
Contributor

@Blitz425 Blitz425 commented Jan 31, 2025

For #5224, will need to be merged at the same time as replacing and adding dialogue for a trainer that isn't in the game at the same time causes it to softlock. Dialogue added is taken from mainline with some parts removed to fit the context of Pokerogue.

Pokecorpus links to all added text:
Colress encounter_1
Colress encounter_2 / Part 2
Colress encounter_3 / Part 2 / Part 3

Colress victory_1
Colress victory_2
Colress victory_3

Kukui encounter_1 / Part 2 / Part 3 / Part 4
Kukui victory_1
Kukui defeat_1 (Currently goes unused in Pokerogue)

Mustard encounter_1 / Part 2 / Part 3 / Part 4
Mustard victory_1 / Part 2
Mustard defeat_1 (Currently goes unused in Pokerogue)

@Madmadness65
Copy link
Contributor

Rood's trainer name entry will need to be deleted from all other languages that has it

@Blitz425 Blitz425 marked this pull request as draft January 31, 2025 07:14
@Blitz425 Blitz425 changed the title Add Dialouge / Name / BGM data for new Trainers, remove and replace data for an old Trainer. Add Dialogue / Name / BGM data for new Trainers, remove and replace data for an old Trainer. Feb 1, 2025
@Blitz425 Blitz425 marked this pull request as ready for review February 1, 2025 20:50
@Adri1 Adri1 merged commit 0b6affd into pagefaultgames:main Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants