-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add Kukui and Mustard as Champions and Colress as an admin. #5224
Conversation
New BGM locale entries will need to be added in the bgm-name.json file.
Wait I thought we already had Colress? |
Nope, adding him was blocked by an ex contributor but his addition has been requested by others and it felt fitting since we're updating Plasma to fully be their BW2 iteration. Colress' sprite WAS sitting around in the files though just being unused. |
A locales update needs to happen at the same time as this PR or beta will not launch |
What are the changes the user will see?
New Champions for the Alola / Galar Elite 4!
Colress is a new admin, replacing Rood.
Why am I making these changes?
Adds more trainer variety to the game and characters like Kukui and Colress were requested characters to be added. Rood didn't make any sense as an admin for Team Plasma, as we're using Team Plasma's BW2 iteration and Rood is long retired and heavily against Team Plasma (and really only has one canonical battle so there is no variety to choose from). Mustard is a champion from Galar similar to Red who held the champion title in the past but still shows up here as a champion. The inclusion of this trainer introduces new and unique Pokemon to fight against such as G-Max Urshifu and is a good inclusion in the case we wish to do anything related to multi battles.
What are the changes from a developer perspective?
Added a new pool for Colress to pull from in his admin fights.
Added champion team data for Kukui / Mustard.
Screenshots/Videos
How to test the changes?
Overrides
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: