Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Kukui and Mustard as Champions and Colress as an admin. #5224

Merged
merged 15 commits into from
Feb 2, 2025

Conversation

Blitz425
Copy link
Contributor

@Blitz425 Blitz425 commented Jan 31, 2025

What are the changes the user will see?

New Champions for the Alola / Galar Elite 4!
Colress is a new admin, replacing Rood.

Why am I making these changes?

Adds more trainer variety to the game and characters like Kukui and Colress were requested characters to be added. Rood didn't make any sense as an admin for Team Plasma, as we're using Team Plasma's BW2 iteration and Rood is long retired and heavily against Team Plasma (and really only has one canonical battle so there is no variety to choose from). Mustard is a champion from Galar similar to Red who held the champion title in the past but still shows up here as a champion. The inclusion of this trainer introduces new and unique Pokemon to fight against such as G-Max Urshifu and is a good inclusion in the case we wish to do anything related to multi battles.

What are the changes from a developer perspective?

Added a new pool for Colress to pull from in his admin fights.
Added champion team data for Kukui / Mustard.

Screenshots/Videos

image
image

How to test the changes?

Overrides

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

@Blitz425 Blitz425 changed the title [ Enhancement ] Add Kukui and Mustard as Champions and Colress as an admin. [Enhancement] Add Kukui and Mustard as Champions and Colress as an admin. Jan 31, 2025
@Madmadness65 Madmadness65 added Enhancement New feature or request Balance Team Specifically a balance team change labels Jan 31, 2025
@DayKev
Copy link
Collaborator

DayKev commented Jan 31, 2025

Wait I thought we already had Colress?

@Blitz425
Copy link
Contributor Author

Wait I thought we already had Colress?

Nope, adding him was blocked by an ex contributor but his addition has been requested by others and it felt fitting since we're updating Plasma to fully be their BW2 iteration. Colress' sprite WAS sitting around in the files though just being unused.

@damocleas damocleas marked this pull request as ready for review February 1, 2025 20:49
@damocleas damocleas requested a review from a team as a code owner February 1, 2025 20:49
@damocleas
Copy link
Collaborator

A locales update needs to happen at the same time as this PR or beta will not launch

@damocleas damocleas added the Game Balance Changes focused on game balance label Feb 1, 2025
@damocleas damocleas merged commit 5c5622e into pagefaultgames:beta Feb 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change Enhancement New feature or request Game Balance Changes focused on game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants