Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELC-4686 fix: changed check on taxCode null in getInstitutions method #242

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

empassaro
Copy link
Contributor

List of Changes

changed check on taxCode null in getInstitutions method

Motivation and Context

improved check using StringUtils.isNotBlank to handle taxCode empty

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@empassaro empassaro requested a review from a team as a code owner April 19, 2024 09:38
@github-actions github-actions bot added the functions Changes are related to functions label Apr 19, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@empassaro empassaro merged commit bc8b7f4 into main Apr 19, 2024
5 of 6 checks passed
@empassaro empassaro deleted the feature/SELC-4686 branch April 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants