Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELC-4686 fix: changed check on taxCode null in getInstitutions method #242

Merged
merged 2 commits into from
Apr 19, 2024
Merged

SELC-4686 fix: changed check on taxCode null in getInstitutions method #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d58b85
SELC-4686 fix: changed check on taxCode null in getInstitutions method
empassaro Apr 19, 2024
0eb5fdd
SELC-4686 fix: junit test
empassaro Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...nctions/src/main/java/it/pagopa/selfcare/onboarding/service/CompletionServiceDefault.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public class CompletionServiceDefault implements CompletionService {
public String createInstitutionAndPersistInstitutionId(Onboarding onboarding) {

Institution institution = onboarding.getInstitution();
InstitutionsResponse institutionsResponse = getInstitutionsByFilters(institution);
InstitutionsResponse institutionsResponse = getInstitutions(institution);
if(Objects.nonNull(institutionsResponse.getInstitutions()) && institutionsResponse.getInstitutions().size() > 1){
throw new GenericOnboardingException("List of institutions is ambiguous, it is empty or has more than one element!!");
}
Expand All @@ -110,9 +110,10 @@ public String createInstitutionAndPersistInstitutionId(Onboarding onboarding) {
return institutionResponse.getId();
}

private InstitutionsResponse getInstitutionsByFilters(Institution institution) {
private InstitutionsResponse getInstitutions(Institution institution) {
InstitutionsResponse institutionsResponse;
if(Objects.nonNull(institution.getTaxCode())) {

if(StringUtils.isNotBlank(institution.getTaxCode())) {
institutionsResponse = institutionApi.getInstitutionsUsingGET(institution.getTaxCode(), institution.getSubunitCode(), null, null);
} else {
String origin = Objects.nonNull(institution.getOrigin()) ? institution.getOrigin().getValue() : null;
Expand Down
Loading