Excavator: Allow Java 17 language features in all modules #7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a Jakarta migration, blocked |
fsamuel-bs
force-pushed
the
roomba/java-17-library-target
branch
from
051199b
to
78a01d5
Compare
fsamuel-bs
reviewed
Oct 30, 2024
| @@ -1518,7 +1518,7 @@ private SingleBatchSweeper getSingleShardSweeper(SettableFuture<MultiTableSweepQ | |||
| */ | |||
| private TimelockService createStickyLockService() { | |||
| AtomicLong lockToken = new AtomicLong(0); | |||
| Set<LockDescriptor> requestedLocks = new ConcurrentHashSet<>(); | |||
| Set<LockDescriptor> requestedLocks = ConcurrentHashMap.newKeySet(); | |||
There was a problem hiding this comment.
Note this code change - only for tests though.
|
Documenting for my future self:
|
carterkozak
reviewed
Oct 31, 2024
| @@ -96,7 +96,7 @@ public Set<String> getSupportedAnnotationTypes() { | |||
|
|
|||
| @Override | |||
| public SourceVersion getSupportedSourceVersion() { | |||
| return SourceVersion.RELEASE_11; | |||
| return SourceVersion.RELEASE_17; | |||
There was a problem hiding this comment.
We can update this to return SourceVersion.latestSupported(); e.g. https://github.com/palantir/delegate-processors/blob/43e5fed7e639e1162e4ccc53e177f4abf3d08915/delegate-processors/src/main/java/com/palantir/delegate/processors/DelegateProcessor.java#L68-L71
that way we don't have to think about it for each upgrade. I'd propose making this sort of change onto develop, so we can rebase the jdk-17 bump and keep it minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/java-17-library-target check.
To enable or disable this check, please contact the maintainers of Excavator.
Also upgrade all references from
javaxtojakarta.