Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Suggest component test failing in React 18 #7170

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ggdouglas
Copy link
Contributor

Copied from React 18 Upgrade feature branch #7142

Skips tests that fail as a result of React 18 and new enzyme wrapper updates. See #7168

@changelog-app
Copy link

changelog-app bot commented Jan 14, 2025

Generate changelog in packages/select/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Skip Suggest component test failing in React 18

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Skip test in suggest failing as a result of React 18 upgrade

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas mentioned this pull request Jan 14, 2025
15 tasks
@ggdouglas ggdouglas merged commit 07f1f48 into develop Jan 15, 2025
12 of 14 checks passed
@ggdouglas ggdouglas deleted the feat/react-18-skip-failing-suggest-test branch January 15, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants