Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X and Y axis for chemrix beam block swapped and tested #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rehan-slac
Copy link

@rehan-slac rehan-slac commented Feb 27, 2025

swapped the beam block X axis with Y axis and vise versa

Description

  • in GVL main changed changed x-axis to m30 and Y-axis to m31
  • in beamblock.prgm swapped x and y
  • swapped bean X and beam Y in Nc task
  • Swapped beamblock X and beamblock y in I/O

Motivation and Context

chemrix beam block was rotated so the axis had to be swapped to correspond to the right location

ECS-7236

How Has This Been Tested?

tested the changes by moving the motors

Where Has This Been Documented?

Screenshots (if appropriate):

image
image

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@rehan-slac rehan-slac marked this pull request as ready for review February 27, 2025 01:22
Copy link
Contributor

@jozamudi jozamudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants