Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoDeploy & KeyCreationService #701

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

RMartinOscar
Copy link
Contributor

Second param of handle() is a 1d array

@RMartinOscar RMartinOscar self-assigned this Nov 7, 2024
@RMartinOscar RMartinOscar added the 🐛 bug Something isn't working label Nov 7, 2024
@RMartinOscar
Copy link
Contributor Author

is there any reason to be able to pass "permissions" in both $data and $pemissions ?

@Boy132
Copy link
Member

Boy132 commented Nov 7, 2024

is there any reason to be able to pass "permissions" in both $data and $pemissions ?

That's probably a leftover from before. You should be fine to combine it/ just use data.

@RMartinOscar
Copy link
Contributor Author

Talking about added complexity i found that generateTokenIdentifier & getPrefixForType take $type as parameter instead of using $this->type is there any reason for those to be static ?
Also the setKeyType setter in KeyCreationService is only used twice in the whole app we should get rid of it.

@notAreYouScared notAreYouScared merged commit 8eebb82 into pelican-dev:main Nov 7, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@RMartinOscar RMartinOscar deleted the fix/autodeploy-keys branch November 7, 2024 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants