Updating eslint config

.github/workflows/linting.yml

@@ -37,7 +37,7 @@ jobs:
         uses: tj-actions/eslint-changed-files@v18
         with:
           config_path: "src/main/webapp/.eslintrc.js"
-          extra_args: "--max-warnings=0"
+          extra_args: "--max-warnings=0 --parser-options project:src/main/webapp/tsconfig.json"
           file_extensions: |
             src/main/webapp/resources/js/**/*.ts
             src/main/webapp/resources/js/**/*.tsx

CHANGELOG.md

@@ -13,6 +13,7 @@
 * [Developer/UI]: Performance enhancements to the metadata uploader. See [PR 1445](https://github.com/phac-nml/irida/pull/1445).
 * [Developer/UI]: Fix for updating sample modified date when metadata is deleted. See [PR 1457](https://github.com/phac-nml/irida/pull/1457).
 * [Developer]: Added support for cloud based storage. Currently, Microsoft Azure Blob and Amazon AWS S3 are supported. [See PR 1194](https://github.com/phac-nml/irida/pull/1194)
+* [UI/Developer]: Updated Eslint config to use `airbnb`. [See PR 1454](https://github.com/phac-nml/irida/pull/1454)
 
 ## [22.09.7] - 2022/01/24
 * [UI]: Fixed bugs on NCBI Export page preventing the NCBI `submission.xml` file from being properly written. See [PR 1451](https://github.com/phac-nml/irida/pull/1451)

build.gradle.kts

@@ -312,6 +312,11 @@ tasks.register<PnpmTask>("cleanWebapp") {
     pnpmCommand.set(listOf("clean"))
 }
 
+tasks.register<PnpmTask>("lintWebapp") {
+    dependsOn(":pnpmInstall")
+    pnpmCommand.set(listOf("lint"))
+}
+
 tasks.register<PnpmTask>("buildWebapp") {
     inputs.files(fileTree("${project.projectDir}/src/main/webapp/resources"))
     inputs.file("${project.projectDir}/src/main/webapp/package.json")

src/main/webapp/.eslintrc.js

@@ -10,14 +10,13 @@ module.exports = {
     __webpack_public_path__: true,
   },
   extends: [
-    "eslint:recommended",
-    "plugin:react/recommended",
-    "plugin:react-hooks/recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
+    "airbnb",
+    "airbnb-typescript",
     "plugin:@typescript-eslint/recommended",
     "plugin:prettier/recommended",
   ],
   parserOptions: {
+    project: "./tsconfig.json",
     ecmaFeatures: {
       jsx: true,
     },
@@ -31,22 +30,11 @@ module.exports = {
     },
   },
   rules: {
-    "react/prop-types": 0,
-    "prefer-destructuring": [
-      "error",
-      {
-        array: true,
-        object: true,
-      },
-      {
-        enforceForRenamedProperties: false,
-      },
-    ],
-    "prettier/prettier": [
-      "error",
-      {
-        endOfLine: "auto",
-      },
-    ],
+    "@typescript-eslint/consistent-type-imports": "warn",
+    "@typescript-eslint/no-unsafe-argument": "warn",
+    "@typescript-eslint/no-unsafe-assignment": "warn",
+    "@typescript-eslint/no-unsafe-call": "warn",
+    "@typescript-eslint/no-unsafe-member-access": "warn",
+    "@typescript-eslint/no-unsafe-return": "warn",
   },
 };

src/main/webapp/package.json

@@ -8,7 +8,7 @@
     "clean": "run-z --then rm -rf dist/ pages/templates/i18n/",
     "test": "run-z --then jest resources/js/**/*.test.js",
     "test_watch": "run-z --then jest --watch resources/js/**/*.test.js",
-    "lint": "run-z --then eslint --ext resources/js/**/*.{js,jsx,ts,tsx}"
+    "lint": "run-z --then eslint --ext .js,.jsx,.ts,.tsx resources/js/"
   },
   "browserslist": [
     "last 2 Chrome versions",
@@ -90,20 +90,23 @@
     "@types/react-virtualized-auto-sizer": "^1.0.1",
     "@types/react-window": "^1.8.5",
     "@types/styled-components": "^5.1.25",
-    "@typescript-eslint/eslint-plugin": "^5.27.0",
-    "@typescript-eslint/parser": "^5.27.0",
+    "@typescript-eslint/eslint-plugin": "^5.50.0",
+    "@typescript-eslint/parser": "^5.50.0",
     "autoprefixer": "^10.4.4",
     "babel-loader": "^8.2.4",
     "babel-plugin-import": "^1.13.5",
     "browserslist": "^4.20.2",
     "css-loader": "^6.7.1",
     "css-minimizer-webpack-plugin": "^3.4.1",
-    "eslint": "^8.13.0",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-react": "^7.29.4",
-    "eslint-plugin-react-hooks": "^4.4.0",
+    "eslint": "^8.32.0",
+    "eslint-config-airbnb": "^19.0.4",
+    "eslint-config-airbnb-typescript": "^17.0.0",
+    "eslint-config-prettier": "^8.6.0",
+    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-jsx-a11y": "^6.7.1",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-react": "^7.32.1",
+    "eslint-plugin-react-hooks": "^4.6.0",
     "expose-loader": "^3.1.0",
     "jest": "^27.5.1",
     "less": "^4.1.2",
@@ -113,13 +116,13 @@
     "postcss-import": "^14.1.0",
     "postcss-loader": "^6.2.1",
     "postcss-preset-env": "^7.4.3",
-    "prettier": "^2.7.1",
+    "prettier": "^2.8.3",
     "properties-reader": "^2.2.0",
     "react-is": "^17.0.2",
     "run-z": "^1.10.1",
     "speed-measure-webpack-plugin": "^1.5.0",
     "terser-webpack-plugin": "^5.3.1",
-    "typescript": "^4.7.2",
+    "typescript": "^4.9.5",
     "webpack": "^5.72.0",
     "webpack-assets-manifest": "^5.1.0",
     "webpack-cli": "^4.9.2"