Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate each metric by kind #96

Closed

Conversation

davydog187
Copy link
Contributor

@davydog187 davydog187 commented Apr 26, 2020

On the metrics page, unless you look at the axis labels and units, it is not obvious what type of metric you're looking at. This manifests when looking at metrics for the same event. The same title will be duplicated each time without displaying the metric.

This PR is mostly to get a conversation started. I'm not sure of the best way to display this information. For now I displayed is as a function acting on the event.

Separately, it also may be nice to display the event_name rather than name, and highlight the measurement separately.

Screen Shot 2020-04-26 at 10 45 40 AM

On the metrics page, unless you look at the axis labels and units, it is
not obvious what type of metric you're looking at. This manifests when
looking at metrics for the same event. The same title will be duplicated
each time without displaying the metric.

This PR is mostly to get a conversation started. I'm not sure of the
best way to display this information. For now I displayed is as a
function acting on the data.

Separately, it also may be nice to display the `event_name` rather than
`name`, and highlight the measurement differently.
@josevalim
Copy link
Member

Theoretically each type would have a different graph. So I would prefer the distinction to be visual somehow, then adding the info as proposed, as that may clutter the UI more. In the worst case, we add those as legends to be axis and curves, rather that directly to the title.

@josevalim
Copy link
Member

To clarify, for the counter, we should fix the Y unit. For last_value and summary there isn't really much difference between them, except we show more information for summary while last_value is a single curve. So I think we can skip the explicit label - the graph should tell us everything we need to know. :)

@davydog187
Copy link
Contributor Author

@josevalim great, i'll make those changes ;)

@josevalim
Copy link
Member

@davydog187 sweet. Also please see #49. We could go with a different short, but i also think we can just use uplot and keep an increasing counter in the client. I will close this one for now!

@josevalim josevalim closed this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants