Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate each metric by kind #96

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/phoenix/live_dashboard/live/chart_component.ex
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,13 @@ defmodule Phoenix.LiveDashboard.ChartComponent do
end

defp chart_title(metric) do
"#{Enum.join(metric.name, ".")}#{chart_tags(metric.tags)}"
"#{chart_type_name(metric)}(#{Enum.join(metric.name, ".")})#{chart_tags(metric.tags)}"
end

defp chart_type_name(%module{}) do
module
|> chart_kind()
|> to_string()
end

defp chart_tags([]), do: ""
Expand Down