-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes: fix issues found during translation review #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The substitution ref-getting-started-find-correct-device is a link to a chapter and resolves to Finding the Correct Device <getting-started-find-correct-device>` in Getting Started. Substitutions should be kept to a minimum and used only when really needed (e.g. linking to platform specific content). Signed-off-by: Jonas Remmert <[email protected]>
The substitution |ref-disable-emmc-part| is a link to a chapter and resolves to :ref:`Disable booting from eMMC boot partitions <emmc-disable-boot-part>` from Linux. Substitutions should be kept to a minimum and used only when really needed (e.g. linking to platform specific content). Signed-off-by: Jonas Remmert <[email protected]>
Some platforms did not link properly to the chapter "Resizing ext4 Root Filesystem". Signed-off-by: Jonas Remmert <[email protected]>
The PD22.1.1 release is based on hardknott. The bsp manual linked kirkstone instead. Signed-off-by: Jonas Remmert <[email protected]>
In order to prepare for a change of global links to internal references for the yocto manual references, the gpio and pcie chapter that uses the linking has to be moved to the leave documents. Those older bsps are based on Yocto hardknott, where no internal yocto manual exist. Once the gpio section is moved, all other manuals can be moved to internal references. Signed-off-by: Jonas Remmert <[email protected]>
When linking to internal (doc-bsp-yocto) documents or chapters, cross-references have advantages over external links. Referencing via external links does not allowed as external links are not sensitive to the currently selected language. Therefor this commit changes all external links to doc-bsp-yocto content to sphinx references. Signed-off-by: Jonas Remmert <[email protected]>
Add a rule that internal chapters have to be linked with sphinx references instead of external links. Signed-off-by: Jonas Remmert <[email protected]>
annie-pixel
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues that have been found while reviewing the translation system.