Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable jemalloc's background thread by default #9813

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Re-enable jemalloc's background thread by default #9813

merged 2 commits into from
Jan 22, 2025

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jan 22, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9812 ref #9722

Problem Summary:

See issue 9812

What is changed and how it works?

Re-enable jemalloc's background thread by default

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue that the memory may stay in high level after large amount of data ingested

@CalvinNeo
enable
e47734e 
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 22, 2025
@CalvinNeo
Copy link
Member Author

/cc @JaySon-Huang @JinheLin @Lloyd-Pottiger

@CalvinNeo CalvinNeo changed the title Enable jemalloc's background thread by default Re-enable jemalloc's background thread by default Jan 22, 2025
@CalvinNeo
cpp
2e028b8 
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 22, 2025
JaySon-Huang
JaySon-Huang approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-22 08:16:44.570552338 +0000 UTC m=+255131.901471734: ☑️ agreed by Lloyd-Pottiger.
  • 2025-01-22 08:55:04.951621763 +0000 UTC m=+257432.282541167: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 9832885 into pingcap:master Jan 22, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 22, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 22, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9813
f1676d8 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9814.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 23, 2025
@ti-chi-bot @CalvinNeo @JaySon-Huang
Re-enable jemalloc's background thread by default (#9813) (#9814)
65a91a3 
ref #9722, close #9812

Re-enable jemalloc's background thread by default

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>

Co-authored-by: Calvin Neo <[email protected]>
Co-authored-by: JaySon-Huang <[email protected]>
Co-authored-by: JaySon <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jan 23, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9819.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 23, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9813
e13954d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9820.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 23, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9813
b70873e 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Jan 23, 2025
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9821.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 23, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9813
13375a9 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 23, 2025
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9822.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 23, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9813
ca24efc 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 23, 2025
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The jemalloc's background thread is disabled
4 participants
@CalvinNeo @ti-chi-bot @JaySon-Huang @Lloyd-Pottiger