Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current ZODB (2nd trial) #320

Closed
wants to merge 2 commits into from
Closed

Use current ZODB (2nd trial) #320

wants to merge 2 commits into from

Conversation

jensens
Copy link
Member

@jensens jensens commented Apr 5, 2017

Tests were red after merge of #317 - we need to figure out what happened - they were green on PR before.

@gforcada
Copy link
Member

gforcada commented Apr 5, 2017

Do you have the link to the jenkins job that failed?

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

Huh, after looking at it, it seems the merge before was the cause of the red Jenkins: http://jenkins.plone.org/job/plone-5.1-python-2.7/1753/
But there were no changes and the next one, finally green, was the ZODB merge: http://jenkins.plone.org/job/plone-5.1-python-2.7/1754/
Overall, this is a bit confusing.

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

Now, the PR fails. I really have no idea what's going on here.

In parallel, I have the tests running local (w/o robot tests) and they seem to pass (still running, but some of the failed ones passed).

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

I start the tests again with more version pins (ZODB dependencies were not pinned).

Unrelated, I also added ZRS and RelStorage to the ecosystem pins in order to help future users to not use outdated versions.

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017 •
edited
Loading

btw., local on my machine all tests are passing (w/o having robot tests run).

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

It fails again, this looks like a machine/setup/jenkins specific problem. I am a bit lost here.

@gforcada
Copy link
Member

gforcada commented Apr 5, 2017

I have no idea, but someting looks really broken: http://jenkins.plone.org/job/pull-request-5.1/1456/consoleFull

@gforcada
Copy link
Member

gforcada commented Apr 5, 2017

Given that the main jobs are green, it has to be due to the changes here...

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

@gforcada given that http://jenkins.plone.org/job/plone-5.1-python-2.7/1754/ was green: I am confused. May you explain this?

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

@gforcada some time (about a year IIRC) we had a similar situation where one node was broken and produced total failure while the others were working. No idea if this is related.

Also, the broken build one commit before the ZODB5 merge in 5.1 branch and the subsequent green build of the merge signaling there is something wrong with Jenkins.

@gforcada
Copy link
Member

gforcada commented Apr 5, 2017

Yes, that's true, node1 was the problematic one, but this last error happened on node5, which together with node6, are the latest nodes we have, and they should be fine...

@jensens
Copy link
Member Author

jensens commented Apr 5, 2017

@gforcada I am still curious why http://jenkins.plone.org/job/plone-5.1-python-2.7/1754/ was green (it was this ZODB change). Any chance to figure out? There must be something unstable in the stack.

@jensens jensens force-pushed the use-current-zodb-2 branch from e3bdcfa to 6d1cbb4 Compare April 12, 2017 13:35
@jensens jensens closed this Apr 12, 2017
@jensens jensens deleted the use-current-zodb-2 branch April 12, 2017 13:41
@jensens jensens mentioned this pull request Apr 12, 2017
Merged
mister-roboto pushed a commit that referenced this pull request Sep 11, 2020
@mauritsvanrees
[fc] Repository: plone.app.event
a10a84c 
Branch: refs/heads/master
Date: 2020-09-10T18:35:56+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.event@368ee0a

Replaced deprecated plone.testing.z2 imports with plone.testing.zope, where possible.

Files changed:
A news/3130.bugfix
M plone/app/event/testing.py
M plone/app/event/tests/test_dx_behaviors.py
M plone/app/event/tests/test_ical_import.py
M plone/app/event/tests/test_recurrence.py
Repository: plone.app.event

Branch: refs/heads/master
Date: 2020-09-10T18:46:02+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.event@1fe753d

Use named behaviors in our test type.

Files changed:
M plone/app/event/profiles/testing/types/plone.app.event.dx.event.xml
Repository: plone.app.event

Branch: refs/heads/master
Date: 2020-09-11T08:47:25+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.event@7cb7ea0

Merge pull request #320 from plone/maurits/fix-warnings-2

Fix deprecation warnings in tests: use plone.testing.zope and named behaviors.

Files changed:
A news/3130.bugfix
M plone/app/event/profiles/testing/types/plone.app.event.dx.event.xml
M plone/app/event/testing.py
M plone/app/event/tests/test_dx_behaviors.py
M plone/app/event/tests/test_ical_import.py
M plone/app/event/tests/test_recurrence.py
mister-roboto pushed a commit that referenced this pull request Sep 11, 2020
@mauritsvanrees
[fc] Repository: plone.app.event
a43983b 
Branch: refs/heads/master
Date: 2020-09-10T18:35:56+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.event@368ee0a

Replaced deprecated plone.testing.z2 imports with plone.testing.zope, where possible.

Files changed:
A news/3130.bugfix
M plone/app/event/testing.py
M plone/app/event/tests/test_dx_behaviors.py
M plone/app/event/tests/test_ical_import.py
M plone/app/event/tests/test_recurrence.py
Repository: plone.app.event

Branch: refs/heads/master
Date: 2020-09-10T18:46:02+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.event@1fe753d

Use named behaviors in our test type.

Files changed:
M plone/app/event/profiles/testing/types/plone.app.event.dx.event.xml
Repository: plone.app.event

Branch: refs/heads/master
Date: 2020-09-11T08:47:25+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.event@7cb7ea0

Merge pull request #320 from plone/maurits/fix-warnings-2

Fix deprecation warnings in tests: use plone.testing.zope and named behaviors.

Files changed:
A news/3130.bugfix
M plone/app/event/profiles/testing/types/plone.app.event.dx.event.xml
M plone/app/event/testing.py
M plone/app/event/tests/test_dx_behaviors.py
M plone/app/event/tests/test_ical_import.py
M plone/app/event/tests/test_recurrence.py
mister-roboto pushed a commit that referenced this pull request Dec 12, 2020
@ale-rt
[fc] Repository: plone.app.dexterity
8bb292d 
Branch: refs/heads/master
Date: 2020-12-12T10:47:34+01:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.app.dexterity@7a4622b

Fix the constraint types mode calculation

Fix the constraint types mode calculation, disabling acquisition and gracefully checking for the existence of a portal type attribute in the container

Fixes #319

Files changed:
A news/319.fixed
M plone/app/dexterity/behaviors/constrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:19:25+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@b643295

Add tests for ConstrainTypesBehavior

Files changed:
A plone/app/dexterity/behaviors/tests/test_contrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:24:09+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@39bbf17

Add correct tests.

Files changed:
M plone/app/dexterity/behaviors/tests/test_contrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:25:11+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@1ed2cad

Bail out early if parent doesn't have portal_type, so we don't try to ACQUIRE

Files changed:
M plone/app/dexterity/behaviors/constrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:26:58+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@0c00b59

cleanup unused imports

Files changed:
M plone/app/dexterity/behaviors/tests/test_contrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T14:21:46+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@bd7148e

Rename 319.fixed to 319.bugfix

Files changed:
A news/319.bugfix
D news/319.fixed
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T15:55:36+01:00
Author: Alessandro Pisa (ale-rt) <[email protected]>
Commit: plone/plone.app.dexterity@0341a5b

Fix the constraint types mode calculation (#320)

* Fix the constraint types mode calculation

Fix the constraint types mode calculation, disabling acquisition and gracefully checking for the existence of a portal type attribute in the container
Add test coverage and cleanup unused imports

Fixes #319

Co-authored-by: Roel Bruggink &lt;[email protected]&gt;

Files changed:
A news/319.bugfix
A plone/app/dexterity/behaviors/tests/test_contrains.py
M plone/app/dexterity/behaviors/constrains.py
mister-roboto pushed a commit that referenced this pull request Dec 12, 2020
@ale-rt
[fc] Repository: plone.app.dexterity
ed92b4a 
Branch: refs/heads/master
Date: 2020-12-12T10:47:34+01:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.app.dexterity@7a4622b

Fix the constraint types mode calculation

Fix the constraint types mode calculation, disabling acquisition and gracefully checking for the existence of a portal type attribute in the container

Fixes #319

Files changed:
A news/319.fixed
M plone/app/dexterity/behaviors/constrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:19:25+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@b643295

Add tests for ConstrainTypesBehavior

Files changed:
A plone/app/dexterity/behaviors/tests/test_contrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:24:09+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@39bbf17

Add correct tests.

Files changed:
M plone/app/dexterity/behaviors/tests/test_contrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:25:11+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@1ed2cad

Bail out early if parent doesn't have portal_type, so we don't try to ACQUIRE

Files changed:
M plone/app/dexterity/behaviors/constrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T13:26:58+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@0c00b59

cleanup unused imports

Files changed:
M plone/app/dexterity/behaviors/tests/test_contrains.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T14:21:46+01:00
Author: Roel Bruggink (jaroel) <[email protected]>
Commit: plone/plone.app.dexterity@bd7148e

Rename 319.fixed to 319.bugfix

Files changed:
A news/319.bugfix
D news/319.fixed
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2020-12-12T15:55:36+01:00
Author: Alessandro Pisa (ale-rt) <[email protected]>
Commit: plone/plone.app.dexterity@0341a5b

Fix the constraint types mode calculation (#320)

* Fix the constraint types mode calculation

Fix the constraint types mode calculation, disabling acquisition and gracefully checking for the existence of a portal type attribute in the container
Add test coverage and cleanup unused imports

Fixes #319

Co-authored-by: Roel Bruggink &lt;[email protected]&gt;

Files changed:
A news/319.bugfix
A plone/app/dexterity/behaviors/tests/test_contrains.py
M plone/app/dexterity/behaviors/constrains.py
mister-roboto pushed a commit that referenced this pull request Aug 18, 2022
@petschki
[fc] Repository: plone.app.layout
d7fae38 
Branch: refs/heads/master
Date: 2022-08-12T12:18:55+02:00
Author: Peter Mathis (petschki) <[email protected]>
Commit: plone/plone.app.layout@6f5dec0

Fix classes for membertools dropdown if toolbar is disabled

Files changed:
M plone/app/layout/viewlets/membertools.pt
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2022-08-12T12:19:52+02:00
Author: Peter Mathis (petschki) <[email protected]>
Commit: plone/plone.app.layout@3ce4535

changenote

Files changed:
A news/320.bugfix
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2022-08-18T06:35:08+02:00
Author: Peter Mathis (petschki) <[email protected]>
Commit: plone/plone.app.layout@06ebf40

Merge pull request #320 from plone/petschki-membertools-dropdown-fix

Files changed:
A news/320.bugfix
M plone/app/layout/viewlets/membertools.pt
mister-roboto pushed a commit that referenced this pull request Jan 3, 2024
@mauritsvanrees
[fc] Repository: plone.app.upgrade
7303c56 
Branch: refs/heads/master
Date: 2023-12-22T23:50:44+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.upgrade@36039db

Remove Archetypes modifiers from portal_modifier early in Plone 6.0 alpha.

CMFEditions already tried to do this, but this might fail in a corner case.
See report at https://community.plone.org/t/upgrading-migrating-from-5-2-6-to-6-0-5-fails/17577
This new upgrade step basically uses the [code from the comment there](https://community.plone.org/t/upgrading-migrating-from-5-2-6-to-6-0-5-fails/17577/6?u=mauritsvanrees).

Files changed:
A news/6003.bugfix
M plone/app/upgrade/v60/alphas.py
M plone/app/upgrade/v60/configure.zcml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2024-01-03T11:39:45+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.upgrade@c05e7c7

Merge pull request #320 from plone/maurits-remove_broken_modifiers

Remove Archetypes modifiers from portal_modifier early

Files changed:
A news/6003.bugfix
M plone/app/upgrade/v60/alphas.py
M plone/app/upgrade/v60/configure.zcml
mister-roboto pushed a commit that referenced this pull request Jan 3, 2024
@mauritsvanrees
[fc] Repository: plone.app.upgrade
d31f6aa 
Branch: refs/heads/master
Date: 2023-12-22T23:50:44+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.upgrade@36039db

Remove Archetypes modifiers from portal_modifier early in Plone 6.0 alpha.

CMFEditions already tried to do this, but this might fail in a corner case.
See report at https://community.plone.org/t/upgrading-migrating-from-5-2-6-to-6-0-5-fails/17577
This new upgrade step basically uses the [code from the comment there](https://community.plone.org/t/upgrading-migrating-from-5-2-6-to-6-0-5-fails/17577/6?u=mauritsvanrees).

Files changed:
A news/6003.bugfix
M plone/app/upgrade/v60/alphas.py
M plone/app/upgrade/v60/configure.zcml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2024-01-03T11:39:45+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.upgrade@c05e7c7

Merge pull request #320 from plone/maurits-remove_broken_modifiers

Remove Archetypes modifiers from portal_modifier early

Files changed:
A news/6003.bugfix
M plone/app/upgrade/v60/alphas.py
M plone/app/upgrade/v60/configure.zcml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
04 type: enhancement 12 prio: high 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jensens @gforcada @mister-roboto