-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix lazy schema for cut
/qcut
when allow_breaks=True
#11287
Conversation
allow_breaks=True
cut
/qcut
when allow_breaks=True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition - some minor remarks though about the testing.
@stinodego I moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcrumiller I refactored the tests as there were a lot of things duplicated. Try to limit to one assert per test - if you want to reuse code or data, use parametrize or fixtures. Most importantly though, the schema wasn't being checked correctly.
After fixing the tests, it turns out the implementation was incorrect. So after I fixed that, everything now works correctly 🎉
cut
/qcut
when allow_breaks=True
cut
/qcut
when allow_breaks=True
cut
/qcut
when allow_breaks=True
cut
/qcut
when allow_breaks=True
Resolves #11255