test(python): tighten assert_frame_equal for LazyFrames (don't collect until after the schema has been checked)
#11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect until after the schema has been checked)
alexander-beedie
requested review from
ritchie46 and
stinodego
as code owners
alexander-beedie
changed the title
assert_frame_equal for LazyFrames (don't collect until after the schema has been checked)assert_frame_equal for LazyFrames (don't collect until after the schema has been checked)
alexander-beedie
force-pushed
the
improve-assert-lazyframes-equal
branch
from
f01145c
to
80a6b52
Compare
stinodego
requested changes
Sep 26, 2023
Co-authored-by: Stijn de Gooijer <[email protected]>
Co-authored-by: Stijn de Gooijer <[email protected]>
|
This is great! This will improve our (semi)static dtype correctness. 👍 |
ritchie46
approved these changes
Sep 27, 2023
romanovacca
pushed a commit
to romanovacca/polars
that referenced
this pull request
Oct 1, 2023
…ect until after the schema has been checked) (pola-rs#11331) Co-authored-by: Stijn de Gooijer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #11287 (comment) (for @stinodego ;)
The act of collecting may resolve the schema before it has been checked, potentially hiding some edge-cases. If given two LazyFrames, only collect after schema verification.
(Also: brings the assert error message formatting a little closer to our newer standard).