ci: run build & unit tests in GH Actions #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we'd get the output only when the test passed, which is not very useful.
The test, in its current form, is incompatible with ASan, since it overwrites $LD_PRELOAD and thus preventing ASan to work properly. This can be worked around using `verify_asan_link_order=0`, but this only shifts the problem down the road, as with that ASan is able to run but produces false positive reports since it can't properly incercept calls made to libduktape.
Introduce a GH Actions job that builds & tests polkit in three "categories" 1) Build with various optimization levels & other build-time options (both clang & gcc) 2) Build & run the unit tests (both clang & gcc) 3) Build & run the unit tests with Address Sanitizer and Undefined Behavior Sanitizer (only gcc for now) There's a couple of outstanding issues that should be taken care of in the near future: - get rid of the gazillion of warnings during compilation so we can build with -Werror (--werror) - fix build with clang >= 17 - make test-polkitbackendjsauthority work under ASan
|
An example of such CI run can be seen in mrc0mmand#1. |
Soon, we plan to remove/replace |
|
Thank you for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a GH Actions job that builds & tests polkit in three
"categories":
Build with various optimization levels & other build-time options
(both clang & gcc)
Build & run the unit tests (both clang & gcc)
Build & run the unit tests with Address Sanitizer and
Undefined Behavior Sanitizer (only gcc for now)
There's a couple of outstanding issues that should be taken care of in
the near future:
build with -Werror (--werror)