Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run build & unit tests in GH Actions #415

Merged
merged 4 commits into from
Jan 30, 2024
Merged

ci: run build & unit tests in GH Actions #415

merged 4 commits into from
Jan 30, 2024

Commits on Jan 3, 2024

  1. test: fix a potential memory leak

    @mrc0mmand
    mrc0mmand committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6d5313c View commit details
    Browse the repository at this point in the history

  2. test: use subprocess.run() to make debugging easier 

    Otherwise we'd get the output only when the test passed, which is not
very useful.
    @mrc0mmand
    mrc0mmand committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b4d7ccc View commit details
    Browse the repository at this point in the history

  3. test: temporarily disable test-polkitbackendjsauthority under ASan 

    The test, in its current form, is incompatible with ASan, since it
overwrites $LD_PRELOAD and thus preventing ASan to work properly. This
can be worked around using `verify_asan_link_order=0`, but this only
shifts the problem down the road, as with that ASan is able to run but
produces false positive reports since it can't properly incercept calls
made to libduktape.
    @mrc0mmand
    mrc0mmand committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    fb7f960 View commit details
    Browse the repository at this point in the history

  4. ci: run build & unit tests in GH Actions 

    Introduce a GH Actions job that builds & tests polkit in three
"categories"

1) Build with various optimization levels & other build-time options
   (both clang & gcc)

2) Build & run the unit tests (both clang & gcc)

3) Build & run the unit tests with Address Sanitizer and
   Undefined Behavior Sanitizer (only gcc for now)

There's a couple of outstanding issues that should be taken care of in
the near future:

 - get rid of the gazillion of warnings during compilation so we can
   build with -Werror (--werror)
 - fix build with clang >= 17
 - make test-polkitbackendjsauthority work under ASan
    @mrc0mmand
    mrc0mmand committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b907563 View commit details
    Browse the repository at this point in the history