Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encodeBase64 not handling uint8 arrays beyond ~100kB #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix encodeBase64 not handling uint8 arrays beyond ~100kB #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/client/src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ export function getCollectionShortNameFromId(id: string): string {
}

export function encodeBase64(value: Uint8Array): string {
return btoa(String.fromCharCode.apply(null, value as unknown as number[]))
// safe base64 encoding which works even with larger arrays
// see https://github.com/mathiasbynens/base64/issues/13
// solution inspired by https://github.com/WebReflection/uint8-to-base64/blob/master/esm/index.js
const output = [];
for (let i = 0; i < value.length; i++)
output.push(String.fromCharCode(value[i]));
return btoa(output.join(''));
}

export function decodeBase64(value: string): Uint8Array {
Expand Down