Data Explorer: Implement row filters and column sorting for duckdb backend #5168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5126 and #5127. It provides the full set of row filter types and column sorting. A lot of the work was in writing the unit tests code (with
yarn test-extension -l positron-duckdb
) to verify correctness, but I was fairly thorough and turned up some bugs while writing the unit tests.DuckDB does not provide stable sorting (i.e. rows may be permuted if the sort keys are equal) so I had to introduce an auxiliary "row_index" field to do an order-preserving sort to make it easier to unit test.