Provide diff with all changes in step-by-step example. #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uekerman
approved these changes
Apr 24, 2023
|
Related to #260 |
fsimonis
reviewed
Jun 2, 2023
Co-authored-by: Frédéric Simonis <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
MakisH
approved these changes
Nov 13, 2023
| @@ -16,6 +16,91 @@ Please add breaking changes here when merged to the `develop` branch. | |||
|
|
|||
| ## preCICE API | |||
|
|
|||
| <!-- Split code block. See https://github.com/precice/precice.github.io/commit/74e377cece4a221e00b5c56b1db3942ec70a6272. --> | |||
There was a problem hiding this comment.
@MakisH Do you have more details on this point? If it is simple: Let's do it now. If it is more complicated: I guess it's not critical and we can just merge.
There was a problem hiding this comment.
I do not understand what you mean. Could you please elaborate what the problem is? I vaguely remember some issue with code highlighting in diff. Normal diff should work.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just prepared this for my thesis and thought it might also be useful for the documentation. It's unfortunately quite lenghty, but there are also many changes. I'm open for suggestions!
Todo
Split code block. See 74e377c. @uekerman , @fsimonis any guidelines?Does not look critical to me. We can also fix this later, if necessary.