-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide diff with all changes in step-by-step example. #262
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
cdf124e
Fix whitespace.
BenjaminRodenberg 6f80833
Provide diff with all changes in step-by-step example.
BenjaminRodenberg b8d80f0
Update action config docs to v3 (#254)
uekerman 073e8da
Merge branch 'master' into precice-v3
BenjaminRodenberg 5b41f63
Merge branch 'master' into porting-summarize-diff
BenjaminRodenberg 7717c88
Move getMaxTimeStepSize inside time loop.
BenjaminRodenberg f1156f2
Update Roadmap
MakisH 389f167
Update fundamentals-roadmap.md
MakisH 862ed69
Use time step, not timestep. (#259)
BenjaminRodenberg 5f27600
Merge branch 'master' into porting-summarize-diff
BenjaminRodenberg 517c42c
Remove language hint in diff (see #260)
BenjaminRodenberg 792208b
Merge branch 'master' into precice-v3
BenjaminRodenberg d1aaf05
Merge branch 'precice-v3' into porting-summarize-diff
BenjaminRodenberg f6a8ced
Update pages/docs/configuration/configuration-action.md
BenjaminRodenberg ad2fffd
Update pages/docs/couple-your-code/couple-your-code-porting-v2-3.md
BenjaminRodenberg 944c69d
Update pages/docs/couple-your-code/couple-your-code-porting-v2-3.md
BenjaminRodenberg 0a43b24
Merge branch 'master' into porting-summarize-diff
BenjaminRodenberg 93d5db8
Reduce diff.
BenjaminRodenberg 6f740b0
Remove unrelated changes.
BenjaminRodenberg f7d52d1
Update w.r.t. read/writeData and std::spans.
BenjaminRodenberg e04a90a
Remove unrelated.
BenjaminRodenberg e5c6ff3
Add note.
BenjaminRodenberg 40160f8
Update pages/docs/couple-your-code/couple-your-code-porting-v2-3.md
BenjaminRodenberg eef3867
Fix setMeshVertices
BenjaminRodenberg 641414f
Merge branch 'porting-summarize-diff' of github.com:precice/precice.g…
BenjaminRodenberg 0401a5a
Update pages/docs/couple-your-code/couple-your-code-porting-v2-3.md
BenjaminRodenberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MakisH Do you have more details on this point? If it is simple: Let's do it now. If it is more complicated: I guess it's not critical and we can just merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what you mean. Could you please elaborate what the problem is? I vaguely remember some issue with code highlighting in diff. Normal diff should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to 74e377c there seems to be some issue with longer code blocks. But let's not worry about it here. I'll open an issue, because we should probably discuss this with @chlorenz and add some general information and guidelines somewhere in the documentation for the documentation.