Speed up test by webmock 22.53sec to 611.60 millis #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
approved these changes
May 29, 2024
grosser
reviewed
May 29, 2024
| gem 'memory_profiler' | ||
| gem 'rake' | ||
|
|
||
| gem 'maxitest' | ||
| gem 'webmock', '~> 3.23' |
There was a problem hiding this comment.
should not be needed
Suggested change
| gem 'webmock', '~> 3.23' | |
| gem 'webmock' |
There was a problem hiding this comment.
I have learned that is always good to add a minimum version so you know you want downgrade by mistake. Also now you can run bundle update and things should work but with depricitions if any. Then do the major bump up.
but I will remove it if you want
There was a problem hiding this comment.
bundler warns on downgrades so I usually don't add any
it adds a lot of clutter when every gem has a version :)
... just leave it I can remove them all whenever they cause an issue
grosser
reviewed
May 29, 2024
|
just rubocop failing |
grosser
reviewed
May 29, 2024
grosser
reviewed
May 29, 2024
test/test_css_parser_loading.rb
Outdated
Comment on lines
9
to
12
| def fixture(*path) | ||
| Pathname(File.expand_path('fixtures', __dir__)) | ||
| .join(*path) | ||
| end |
There was a problem hiding this comment.
this should get removed now
⋊> ~/D/c/t/fixtures on v2-webmock ⨯ time be rake test 16:20:14 (in /Users/simon/Downloads/css_parser) /Users/simon/.asdf/installs/ruby/3.2.2/bin/ruby -w -I"lib" /Users/simon/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/rule_set/declarations/test_value.rb" "test/rule_set/test_declarations.rb" "test/test_css_parser_basic.rb" "test/test_css_parser_loading.rb" "test/test_css_parser_media_types.rb" "test/test_css_parser_misc.rb" "test/test_css_parser_offset_capture.rb" "test/test_css_parser_regexps.rb" "test/test_helper.rb" "test/test_merging.rb" "test/test_rule_set.rb" "test/test_rule_set_creating_shorthand.rb" "test/test_rule_set_expanding_shorthand.rb" Run options: --seed 58367 # Running: ........................................................................................................................................................................................................... Finished in 21.866189s, 9.2837 runs/s, 30.0464 assertions/s. 203 runs, 657 assertions, 0 failures, 0 errors, 0 skips ________________________________________________________ Executed in 22.53 secs fish external usr time 448.40 millis 139.00 micros 448.27 millis sys time 153.05 millis 984.00 micros 152.06 millis ⋊> ~/D/c/t/fixtures on v2-webmock ⨯ time be rake test 16:20:01 (in /Users/simon/Downloads/css_parser) /Users/simon/.asdf/installs/ruby/3.2.2/bin/ruby -w -I"lib" /Users/simon/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/rule_set/declarations/test_value.rb" "test/rule_set/test_declarations.rb" "test/test_css_parser_basic.rb" "test/test_css_parser_loading.rb" "test/test_css_parser_media_types.rb" "test/test_css_parser_misc.rb" "test/test_css_parser_offset_capture.rb" "test/test_css_parser_regexps.rb" "test/test_helper.rb" "test/test_merging.rb" "test/test_rule_set.rb" "test/test_rule_set_creating_shorthand.rb" "test/test_rule_set_expanding_shorthand.rb" Run options: --seed 27120 # Running: ........................................................................................................................................................................................................... Finished in 0.047695s, 4256.2113 runs/s, 13775.0288 assertions/s. 203 runs, 657 assertions, 0 failures, 0 errors, 0 skips ________________________________________________________ Executed in 611.60 millis fish external usr time 356.27 millis 0.09 millis 356.17 millis sys time 106.73 millis 1.31 millis 105.42 millis
|
fixed |
|
FYI misc small fixes #163 .vscode should go into your global ~/.gitignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why and what is being done.
Pre-Merge Checklist