Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up test by webmock 22.53sec to 611.60 millis #162

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Speed up test by webmock 22.53sec to 611.60 millis #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ gemspec

gem 'benchmark-ips'
gem 'bump'
gem 'maxitest'
gem 'memory_profiler'
gem 'rake'
gem 'rubocop'
gem 'rubocop-rake'
gem 'webrick'

gem 'maxitest'
gem 'webmock', '~> 3.23'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be needed

Suggested change
gem 'webmock', '~> 3.23'
gem 'webmock'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have learned that is always good to add a minimum version so you know you want downgrade by mistake. Also now you can run bundle update and things should work but with depricitions if any. Then do the major bump up.

but I will remove it if you want

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundler warns on downgrades so I usually don't add any
it adds a lot of clutter when every gem has a version :)
... just leave it I can remove them all whenever they cause an issue


gem 'debug', '~> 1.9', platforms: [:mri, :mingw, :x64_mingw]
gem 'rubocop'
gem 'rubocop-rake'
13 changes: 11 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,17 @@ GEM
public_suffix (>= 2.0.2, < 6.0)
ast (2.4.2)
benchmark-ips (2.13.0)
bigdecimal (3.1.8)
bigdecimal (3.1.8-java)
bump (0.10.0)
crack (1.0.0)
bigdecimal
rexml
crass (1.0.6)
debug (1.9.2)
irb (~> 1.10)
reline (>= 0.3.8)
hashdiff (1.1.0)
io-console (0.7.2)
io-console (0.7.2-java)
irb (1.13.1)
Expand Down Expand Up @@ -67,7 +73,10 @@ GEM
ruby-progressbar (1.13.0)
stringio (3.1.0)
unicode-display_width (2.5.0)
webrick (1.8.1)
webmock (3.23.1)
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)

PLATFORMS
arm64-darwin-22
Expand All @@ -84,7 +93,7 @@ DEPENDENCIES
rake
rubocop
rubocop-rake
webrick
webmock (~> 3.23)

BUNDLED WITH
2.4.12
Loading