Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: partial of #3226, set TS back to v4.7.4 #3228

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Nov 17, 2022

Renovate merged the TS update, though tests were failing: #3226

This reverts the update for projects failing.

The failing tests since #3226 was merged are

  • libraries (type-graphql, library, ubuntu-latest)
     Interface 'ExecutionResult<TData>' incorrectly extends interface 'ExecutionResult<{ [key: string]: any; }, { [key: string]: any; }>'.
    
  • libraries (apollo-server, library, ubuntu-latest)
     Type 'TArgs' does not satisfy the constraint 'Record<string, any>'.
    
  • platforms-serverless (firebase-functions, library, ubuntu-latest): node_modules/@types/node/globals.d.ts#L85
     Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '*** new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; ***', but here has type '*** new (): AbortSignal; prototype: AbortSignal; ***'.
    
  • platforms-serverless (firebase-functions, binary, ubuntu-latest): node_modules/@types/node/globals.d.ts#L85
     Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '*** new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; ***', but here has type '*** new (): AbortSignal; prototype: AbortSignal; ***'.
    

Problems

About Apollo, see

Renovate merged the TS update, though tests were failing:
#3226

This reverts the update for projects failing.
@Jolg42 Jolg42 added this to the 4.7.0 milestone Nov 17, 2022
@janpio
Copy link
Contributor

janpio commented Nov 17, 2022

Weird that it merged although tests were failing.

@Jolg42
Copy link
Contributor Author

Jolg42 commented Nov 17, 2022

Issue about outdated apollo-server and graphql dependencies #3229

@Jolg42
Copy link
Contributor Author

Jolg42 commented Nov 17, 2022

Issue about outdated firebase-admin dependency
#3230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants