Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix CRAN submission #184

Merged
merged 11 commits into from
Jan 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
^_pkgdown\.yml$
^docs$
^pkgdown$
^cran-comments\.md$
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,14 @@ jobs:
CURRENT_VERSION=$(grep Version DESCRIPTION | sed 's/Version: \(.*\).9000/\1/g')
sed -i -E "s/$CURRENT_VERSION/${{ steps.release_version.outputs.version }}/g" index.md
sed -i -E "s/$CURRENT_VERSION/${{ steps.release_version.outputs.version }}/g" README.md
sed -i -E "s/$CURRENT_VERSION/${{ steps.release_version.outputs.version }}/g" cran-comments.md
sed -i -E 's/Version: .*/Version: ${{ steps.release_version.outputs.version }}/g' DESCRIPTION

- name: Commit with the release version
run: |
git add index.md
git add README.md
git add cran-comments.md
git add DESCRIPTION
git commit -m "[RELEASE] Set the release version to ${{ steps.release_version.outputs.version }}"
git push
Expand Down
7 changes: 4 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,17 @@ Authors@R: c(person("Celine", "Souchet", role = c("aut", "cre"), email = "proces
Description: To visualize the execution data of the processes on BPMN (Business Process Model and Notation) diagrams, using overlays, style customization and interactions, with the bpmn-visualization TypeScript library.
License: Apache License (== 2)
Copyright: Bonitasoft S.A.
URL: https://process-analytics.github.io/bpmn-visualization-R, https://github.com/process-analytics/bpmn-visualization-R
BugReports: https://github.com/process-analytics/bpmn-visualization-R/issues
URL: https://process-analytics.github.io/bpmn-visualization-R/, https://github.com/process-analytics/bpmn-visualization-R/
BugReports: https://github.com/process-analytics/bpmn-visualization-R/issues/
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.2.3
Imports:
htmlwidgets,
rlang,
xml2
Suggests:
shiny,
spelling,
testthat (>= 3.0.0)
Config/testthat/edition: 3
Language: en-US
67 changes: 67 additions & 0 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,73 @@ A PR can only be merged into master by a maintainer, if all of these conditions

Maintainers need to perform the following actions **in the order described here** to push out a release.

### Preparing a CRAN submission with `rhub`

Before starting a release, check that the output of `rhub` package is stored in [cran-comments.md](cran-comments.md) (the recent output is at the top of the file, and the oldest at the bottom).
If this is not the case, you must perform the following steps.

#### First installation
```R
install.packages("rhub")
library(rhub)
```

For the email address of the maintainer (described in [DESCRIPTION](DESCRIPTION)), `rhub` will prompt you to generate a token (on the first check), or you can [reuse one](https://r-hub.github.io/rhub/reference/validate_email.html).

#### Check
Follow this procedure: https://r-hub.github.io/rhub/articles/rhub.html#prepare-a-cran-submission.

```R
cran_prep <- check_for_cran()
```

⚠️ Locally, you can only see one run of the environment.
To see the other one, you can get the URLs from the top of the local run, and open it on a browser.

Example:
```R
─ Preparing build, see status at
https://builder.r-hub.io/status/bpmnVisualizationR_X.Y.Z.tar.gz-A
https://builder.r-hub.io/status/bpmnVisualizationR_X.Y.Z.tar.gz-B
https://builder.r-hub.io/status/bpmnVisualizationR_X.Y.Z.tar.gz-C
```

#### Post processing
In [cran-comments.md](cran-comments.md):
- At the top, add this template:
```mdxjs
# bpmnVisualizationR <X.Y.Z>.9000

This is a <re-submission | new submission>. In this version, we have:

* <NEW CHANGE>

## Test environments
<RESULT OF check_for_cran()>

## R CMD check results
<RESULT OF check_for_cran()>

## Response to CRAN for last submission

> <CITATION>
```
- Choose if this is a `re-submission` or a `new submission`.
- Add the new change of this version.
- Copy and paste the output of the following command, after receiving the emails for all environments on the maintainer's [email address](DESCRIPTION) from `check_for_cran()`:
```R
cran_prep$cran_summary()
```
- Remove all `Version contains large components (X.Y.Z.9000)"`
- If this is a `re-submission`, copy and paste the result for the last CRAN submission, and answer to false NOTES.
Otherwise, remove the part:
```mdxjs
## Response to CRAN for last submission

> <CITATION>
```


### GitHub issues and milestones update

**Note:** we always put issues related to a version in a Milestone whose name matches the version.
Expand Down
51 changes: 51 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# bpmnVisualizationR 0.3.0.9000

This is a re-submission. In this version, we have:

* Corrected the URLs and removed the `LazyData` field in the [DESCRIPTION](DESCRIPTION) file.
* Added a new file ([WORDLIST](inst/WORDLIST)) to allow custom words with `spelling` package.


## Test environments
- R-hub windows-x86_64-devel (r-devel)
- R-hub ubuntu-gcc-release (r-release)
- R-hub fedora-clang-devel (r-devel)

## R CMD check results
❯ On ubuntu-gcc-release (r-release)
checking CRAN incoming feasibility ... NOTE
Maintainer: ‘Celine Souchet <[email protected]>’

New submission

Possibly misspelled words in DESCRIPTION:
bpmn (7:182)
BPMN (3:44, 7:66)
TypeScript (7:201)

❯ On fedora-clang-devel (r-devel)
checking CRAN incoming feasibility ... [5s/16s] NOTE
Maintainer: ‘Celine Souchet <[email protected]>’

New submission

Possibly misspelled words in DESCRIPTION:
BPMN (3:44, 7:66)
TypeScript (7:201)
bpmn (7:182)

❯ On fedora-clang-devel (r-devel)
checking HTML version of manual ... NOTE
Skipping checking HTML validation: no command 'tidy' found

0 errors ✔ | 0 warnings ✔ | 3 notes ✖

## Response to CRAN for last submission

> Possibly misspelled words in DESCRIPTION:
> BPMN (3:44, 7:66)
> TypeScript (7:201)
> bpmn (7:182)


These words are spelled correctly. They have been added to the [WORDLIST](inst/WORDLIST) file.
12 changes: 12 additions & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
BPMN
Bonitasoft
CMD
Devtools
Rmd
TypeScript
bpmn
css
devtools
htmlwidgets
widget's
6 changes: 3 additions & 3 deletions man/bpmnVisualizationR-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions tests/spelling.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
if(requireNamespace('spelling', quietly = TRUE))
spelling::spell_check_test(vignettes = TRUE, error = FALSE,
skip_on_cran = TRUE)