Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fix CRAN submission #184

Merged
merged 11 commits into from
Jan 11, 2023
Merged

[DOC] Fix CRAN submission #184

merged 11 commits into from
Jan 11, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jan 10, 2023 •
edited
Loading

Fix the last submission: #10 (comment)

Status ok : https://builder.r-hub.io/status/bpmnVisualizationR_0.3.0.9000.tar.gz-a9d46a21e09ee0ab9e90fc169cf6f824

Changes:

  • Corrected the URLs and removed LazyData field in the DESCRIPTION file.
  • Added a new file WORDLIST to allow custom words with spelling package.
  • Updated the documentation of the maintainers to execute rhub package before starting a new release
  • Added a new file cran-comments.md for the CRAN submission
  • Updated the release workflow to update the last version in cran-comments.md

@csouchet csouchet added the documentation Improvements or additions to documentation label Jan 10, 2023
@csouchet csouchet changed the title [DOC] Fix urls [DOC] Fix CRAN submission Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Jan 10, 2023 •
edited
Loading

🎊 PR Preview b5f689e has been successfully built and deployed to https://process-analytics-bpmn-visualization-R-pr_preview-pr-184.surge.sh

🕐 Build time: 0.013s

🤖 By surge-preview

@csouchet csouchet force-pushed the fix_cran_submission branch from cb9dea9 to c4c91df Compare January 10, 2023 13:14
tbouffard
tbouffard reviewed Jan 10, 2023
View reviewed changes
cran-comments.md Outdated Show resolved Hide resolved
@csouchet csouchet force-pushed the fix_cran_submission branch from 2261155 to 1d54c67 Compare January 11, 2023 10:48
@csouchet csouchet marked this pull request as ready for review January 11, 2023 10:48
@csouchet csouchet requested a review from tbouffard January 11, 2023 10:53
tbouffard
tbouffard reviewed Jan 11, 2023
View reviewed changes
MAINTAINERS.md Outdated Show resolved Hide resolved
@tbouffard tbouffard mentioned this pull request Jan 11, 2023
Open
tbouffard
tbouffard approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Could you add a few sentences in the commits to summarize the changes (and if possible in the PR description). This will help while reviewing the commit (and PR) in the future. Thanks in advance

@csouchet csouchet merged commit ed33aec into main Jan 11, 2023
@csouchet csouchet deleted the fix_cran_submission branch January 11, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard