Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix CRAN submission #184

Merged
merged 11 commits into from
Jan 11, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
^_pkgdown\.yml$
^docs$
^pkgdown$
^cran-comments\.md$
6 changes: 4 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ Authors@R: c(person("Celine", "Souchet", role = c("aut", "cre"), email = "proces
Description: To visualize the execution data of the processes on BPMN (Business Process Model and Notation) diagrams, using overlays, style customization and interactions, with the bpmn-visualization TypeScript library.
License: Apache License (== 2)
Copyright: Bonitasoft S.A.
URL: https://process-analytics.github.io/bpmn-visualization-R, https://github.com/process-analytics/bpmn-visualization-R
BugReports: https://github.com/process-analytics/bpmn-visualization-R/issues
URL: https://process-analytics.github.io/bpmn-visualization-R/, https://github.com/process-analytics/bpmn-visualization-R/
BugReports: https://github.com/process-analytics/bpmn-visualization-R/issues/
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.2.3
Expand All @@ -18,5 +18,7 @@ Imports:
xml2
Suggests:
shiny,
spelling,
testthat (>= 3.0.0)
Config/testthat/edition: 3
Language: en-US
17 changes: 17 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Release summary

This is a resubmission. In this version, I have:

* Fixed the URLs in the DESCRIPTION file.
* Added a new file ([WORDLIST](inst%2FWORDLIST)) to allow custom words
csouchet marked this conversation as resolved.
Show resolved Hide resolved

## R CMD check results

0 errors | 0 warnings | 0 note

## Possibly misspelled words in DESCRIPTION from the last submission
BPMN (3:44, 7:66)
TypeScript (7:201)
bpmn (7:182)

These words are spelled correctly. They have been added to the [WORDLIST](inst%2FWORDLIST) file.
12 changes: 12 additions & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
BPMN
Bonitasoft
CMD
Devtools
Rmd
TypeScript
bpmn
css
devtools
htmlwidgets
widget's
6 changes: 3 additions & 3 deletions man/bpmnVisualizationR-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions tests/spelling.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
if(requireNamespace('spelling', quietly = TRUE))
spelling::spell_check_test(vignettes = TRUE, error = FALSE,
skip_on_cran = TRUE)