Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes to version 1.26.2 #552

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Upgrade Kubernetes to version 1.26.2 #552

merged 5 commits into from
Aug 9, 2023

Conversation

astefanutti
Copy link
Contributor

@astefanutti astefanutti commented Aug 7, 2023

This PR upgrades Kubernetes dependencies to v1.26.2.

This also upgrades Go to version 1.19, as it's required by Kubernetes v1.26.

Fixes #524.

@openshift-ci openshift-ci bot requested review from asm582 and dimakis August 7, 2023 14:40
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 8, 2023
@z103cb z103cb removed the lgtm label Aug 8, 2023
@astefanutti astefanutti changed the title Upgrade Kubernetes to version 1.25.4 Upgrade Kubernetes to version 1.26.2 Aug 8, 2023
@z103cb
Copy link
Contributor

z103cb commented Aug 8, 2023

@astefanutti we need to upgrade the kind images to match the k8s version. The version to use would be for 1.25:

kindest/node:v1.25.11@sha256:227fa11ce74ea76a0474eeefb84cb75d8dad1b08638371ecf0e86259b35be0c8

For other versions consult this page: https://github.com/kubernetes-sigs/kind/releases

The configuration file is in: hack/e2e-kind-config.yaml.

It is LGTM otherwise.

@asm582
Copy link
Member

asm582 commented Aug 8, 2023

Thanks @astefanutti , will this upgrade break InstaScale integration?

@astefanutti
Copy link
Contributor Author

@z103cb KinD upgrade done in c461f11.

@astefanutti
Copy link
Contributor Author

Thanks @astefanutti , will this upgrade break InstaScale integration?

@asm582 I don't think so as this PR does not touch the AppWrapper API.

@astefanutti
Copy link
Contributor Author

/hold

There is a CodeFlare release going on. This PR should be merged once the release is done.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2023
@z103cb
Copy link
Contributor

z103cb commented Aug 9, 2023

/LGTM

@astefanutti
Copy link
Contributor Author

/unhold

@openshift-merge-robot openshift-merge-robot merged commit ab92337 into project-codeflare:main Aug 9, 2023
1 check passed
@astefanutti astefanutti deleted the pr-08 branch August 9, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCAD Multi-Cluster using an old k8s version
4 participants