feat(authn): add generic oidc and allow customizable name #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babs
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 124 124
Lines 26054 26054
=======================================
Hits 23828 23828
Misses 1657 1657
Partials 569 569
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andaaron
reviewed
Aug 11, 2023
|
fix commit message (doc(authn) -> docs(authn)) |
rchincha
reviewed
Aug 16, 2023
rchincha
reviewed
Aug 22, 2023
andaaron
reviewed
Aug 23, 2023
|
rebased and squashed |
Rebased and squashed Signed-off-by: Damien Degois <[email protected]>
|
@babs thank you. |
andaaron
approved these changes
Aug 24, 2023
eusebiu-constantin-petu-dbk
approved these changes
Aug 24, 2023
raulkele
pushed a commit
to project-zot/zui
that referenced
this pull request
Aug 28, 2023
Rebased and modified to reflect project-zot/zot#1691 conclusion Signed-off-by: Damien Degois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
none
What does this PR do / Why do we need it:
This PR allow admin to add generic OIDC provider and customize it's name (linked with zui: project-zot/zui#375)
Will this break upgrades or downgrades?
Won't break on upgrade / downgrades
Does this PR introduce any user-facing change?:
It allows the display of a customizable login button with the proper patch on zui (PR project-zot/zui#375)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.