feat: add customizable generic oidc login button #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 87.50% 86.87% -0.64%
==========================================
Files 52 52
Lines 1529 1531 +2
Branches 399 400 +1
==========================================
- Hits 1338 1330 -8
- Misses 179 189 +10
Partials 12 12
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raulkele
approved these changes
Aug 12, 2023
|
Integration test patch is merged, you can rebase the branch |
|
@raulkele done :) |
andaaron
approved these changes
Aug 16, 2023
|
There is still a debate on zot about keeping dex keyword. |
|
@babs, @raulkele, I have merged project-zot/zot#1691 on backend side. |
|
I'll adapt the PR accordingly, rebase and squash |
rchincha
reviewed
Aug 24, 2023
|
After rebase, from my point of view, we can merge this PR |
Rebased and modified to reflect project-zot/zot#1691 conclusion Signed-off-by: Damien Degois <[email protected]>
|
Rebase done with removal of DEX reference as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What does this PR do / Why do we need it:
This PR allow usage of generic OIDC with customizable name (linked to zot project-zot/zot#1691)
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Won't break on upgrade / downgrades
Does this change require updates to the CNI daemonset config files to work?:
no
Does this PR introduce any user-facing change?:
If enabled on backend, it allows the display of a customizable login button
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.