Add Kubernetes CRD Annotations to Duration Type #708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Kubernetes CRD kube builder annotations to the
Duration
type to improve compatibility with Kubernetes Custom Resource Definitions.Background
The
Duration
type currently has a custom JSON serialisation that implicitly converts to a string:Changes
Added annotations to
type Duration time.Duration
inmodel/time.go
:These annotations resolve serialization conflicts when
Duration
is used in Kubernetes CRDs, allowing for correct validation and serialisation in Kubernetes environments while maintaining the existing string serialisation behaviour.Impact
Testing
Duration
behaviorfixes perses/perses-operator#20