Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-functionality section #infragram #322 fixed #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stylebytemi
Copy link

Hello @TildaDares @jywarren , I edited line 79 by adding display flex and justify content space evenly, 168 by removing display none and I changed line 170-172 to 170-174 by creating a Div, giving the Div a class lastzone and styling (display flex and justify content space evenly), I also changed the size of the button from large to small.

Kindly review the changes. Thanks.

Infragram FTO Issue fixed by Temiloluwa Adewale @stylebytemi #showresult

@welcome
Copy link

welcome bot commented Apr 6, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

@stylebytemi stylebytemi changed the title newcommit Non-functionality section #infragram #322 fixed Apr 6, 2022
@jywarren
Copy link
Member

jywarren commented Apr 7, 2022

Hi, would you be able to show a screenshot of before/after? Thank you!

@stylebytemi
Copy link
Author

@jywarren Hello, I'm sorry for the late reply. Trust you're having a great weekend. Kindly view screenshots to show what the before and after looks like
Infragram FTO Issue fixed by Temiloluwa Adewale @stylebytemi
2 Infragram FTO Issue by Temiloluwa Adewale
.

@@ -165,11 +165,13 @@ <h1><img src="assets/infragram-logo.png" alt="Infragram logo image." style="floa
</div>
</div>

<div class="zone last" id="save-zone" style="display:none;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see! Thank you @stylebytemi however one reason we have the buttons hidden initially is because before you begin uploading something, there is nothing to save, so we thought it best to hide them. An alternative could be to have them present but greyed out, but it still adds some perhaps unnecessary clutter to the page before those buttons can even be used. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jywarren, I assume a design proposal to solve the unnecessary clutter has been raised multiple times. However, I will suggest we leave it displayed to avoid confusion for users. My design suggestion would also be that of others which is to use a bootstrap property such as dropdown for clearer display. we can also use react routing and give each column(Div) used in toolbar a new tag which directly links to a clearer and well detailed page. I'm sorry for the late reply. Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants