Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-functionality section #infragram #322 fixed #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Non-functionality section #infragram #322 fixed #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ <h1><img src="assets/infragram-logo.png" alt="Infragram logo image." style="floa

<div class="content">

<div id="toolbar">
<div id="toolbar" style="display: flex;justify-content: space-evenly;">

<div class="zone">
<div class="zone" >
<p>QUICK START</p>
<div class="btn-group">
<a target="_blank" href="http://publiclab.org/wiki/infragram-sandbox" id="btn-webcam" type="button" class="btn btn-lg btn-default"><i class="fa fa-question-circle"></i></a>
Expand Down Expand Up @@ -165,11 +165,13 @@ <h1><img src="assets/infragram-logo.png" alt="Infragram logo image." style="floa
</div>
</div>

<div class="zone last" id="save-zone" style="display:none;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see! Thank you @stylebytemi however one reason we have the buttons hidden initially is because before you begin uploading something, there is nothing to save, so we thought it best to hide them. An alternative could be to have them present but greyed out, but it still adds some perhaps unnecessary clutter to the page before those buttons can even be used. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jywarren, I assume a design proposal to solve the unnecessary clutter has been raised multiple times. However, I will suggest we leave it displayed to avoid confusion for users. My design suggestion would also be that of others which is to use a bootstrap property such as dropdown for clearer display. we can also use react routing and give each column(Div) used in toolbar a new tag which directly links to a clearer and well detailed page. I'm sorry for the late reply. Thanks for your time.

<div class="zone last" id="save-zone">
<p>OUTPUT</p>
<button onClick="openInPl()" type="button" class="btn btn-primary btn-lg">Save</button>
<button onClick="infragram.download()" type="button" class="btn btn-primary btn-lg">Download</button>
<button onClick="openInSequencer()" type="button" class="btn btn-primary btn-lg">Export</button>
<div class="lastzone" style="display: flex; justify-content: space-evenly;">
<button onClick="openInPl()" type="button" class="btn btn-primary btn-sm">Save</button>
<button onClick="infragram.download()" type="button" class="btn btn-primary btn-sm">Download</button>
<button onClick="openInSequencer()" type="button" class="btn btn-primary btn-sm">Export</button>
</div>
</div>

<br style="clear:both;" />
Expand Down
Loading