chore: fix downstream_checks.py #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2918 +/- ##
=======================================
Coverage 67.74% 67.75%
=======================================
Files 331 331
Lines 42203 42203
=======================================
+ Hits 28590 28593 +3
+ Misses 12020 12018 -2
+ Partials 1593 1592 -1 ☔ View full report in Codecov by Sentry. |
guineveresaenger
approved these changes
Feb 27, 2025
| "awsx", | ||
| "eks", | ||
| "terraform-module", | ||
| ] |
There was a problem hiding this comment.
yes! I ran into this and completely forgot to follow up. Thank you.
|
This PR has been shipped in release v3.104.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2917
The script was confusing to me. It printed SKIPPED for jobs that failed. It is too easy to miss failure.
It was writing MISSING for cases where some jobs may still be in progress.
It also tried to handle providers such as awsx that are not bridged - best exclude these.