Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix downstream_checks.py #2918

Merged
merged 1 commit into from
Feb 27, 2025
Merged

chore: fix downstream_checks.py #2918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions scripts/downstream_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
from typing import Any, Iterator
import argparse
import subprocess as sp

import requests

NOT_BRIDGED_PROVIDERS = [
"aws-apigateway",
"awsx",
"eks",
"terraform-module",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! I ran into this and completely forgot to follow up. Thank you.


QUERY = """
{
Expand Down Expand Up @@ -48,7 +53,7 @@ def get_provider_map() -> dict[str, bool]:
resp = requests.get(
"https://raw.githubusercontent.com/pulumi/ci-mgmt/master/provider-ci/providers.json"
)
return {k: False for k in resp.json()}
return {k: False for k in resp.json() if k not in NOT_BRIDGED_PROVIDERS}


def get_title(query_result: Any) -> str:
Expand Down Expand Up @@ -135,10 +140,15 @@ def main():
sp.check_call(["gh", "pr", "close", url])
else:
if not closed or show_closed:
print(sentinel_status, url)
# If the sentinel is SKIPPED, this very likely means the PR failed some checks.
if sentinel_status == "SKIPPED":
print('FAILED:', url)
else:
print(sentinel_status, url)

for missing_repo in {repo for repo in provider_map if not provider_map[repo]}:
print("MISSING", repo_actions_url(missing_repo))
# Possibly waiting for plumbing to propagate, we do not know for sure.
print("WAITING", missing_repo)


if __name__ == "__main__":
Expand Down
Loading