Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/MAINT]: Tidy CI files and uncompatible dependencies versions #15

Merged
merged 18 commits into from
Nov 3, 2024

Conversation

echedey-ls
Copy link
Member

  • Removed usual pip requirements that were not really necessary to specify the versions to tests against (a maintenance burden, I did not think about making the install requirements step optional at first)
  • Kept & updated minimal versions to use exact version matching (better than ~=)
  • Updated the pyproject.toml dependencies versions to match what really is compatible after recent changes and on the lowest supported version.
  • Pinned docs dependencies to minor versions to avoid unexpected changes in the future, now that RTD is finally set up.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

This reverts commit c8ef686, reversing
changes made to 2937e21.
@echedey-ls
Copy link
Member Author

Merge after #13

@adriesse
Copy link
Contributor

adriesse commented Nov 2, 2024

@echedey-ls Could you include the tests in the distribution package while you're at it?

@echedey-ls
Copy link
Member Author

echedey-ls commented Nov 2, 2024

@adriesse do you mean shipping them in the wheel too? They already are in the source distribution.

EDIT: for reference, see these files in https://pypi.org/project/pvpltools/#files

@echedey-ls
Copy link
Member Author

@echedey-ls Could you include the tests in the distribution package while you're at it?

I've created #16 for that, so you can decide on it and atomically revert that change if you want in the future.

@echedey-ls echedey-ls merged commit 0bbd1e7 into main Nov 3, 2024
25 checks passed
@echedey-ls echedey-ls deleted the tidy-ci-testing-files branch November 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants