Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Add tests back to the wheel #16

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

echedey-ls
Copy link
Member

@echedey-ls echedey-ls commented Nov 3, 2024

Addressing @adriesse's comment:

#15 (comment)

I discourage against including them, branch main allows a place for test data that an end-user wouldn't need in their installs. Source always has the tests, so even in the rare case somebody needs them, they can extract the project from source distro. It's also fairly true that for the current size of the tests & their data (100kB), it's impact is negligible in download/install time.

It's up to you whether or not to merge this PR.

EDIT: you can revert back whenever you want, that's why I've made this stand-alone PR for that.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@adriesse
Copy link
Contributor

adriesse commented Nov 4, 2024

Addressing @adriesse's comment:

#15 (comment)

I discourage against including them, branch main allows a place for test data that an end-user wouldn't need in their installs. Source always has the tests, so even in the rare case somebody needs them, they can extract the project from source distro. It's also fairly true that for the current size of the tests & their data (100kB), it's impact is negligible in download/install time.

There is a blurry distinction between examples and tests. At this point neither are adequate in this repo but for the time being they support each other!

EDIT: you can revert back whenever you want, that's why I've made this stand-alone PR for that.

Good idea!

@adriesse adriesse merged commit 77b79b2 into main Nov 4, 2024
24 checks passed
@echedey-ls echedey-ls deleted the add-tests-to-wheel branch November 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants