Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dtypes #798

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Refactor dtypes #798

merged 3 commits into from
Oct 23, 2024

Conversation

hameerabbasi
Copy link
Collaborator

  • Small adjustments.
  • dtype refactor

@hameerabbasi hameerabbasi self-assigned this Oct 23, 2024
@hameerabbasi hameerabbasi added enhancement Indicates new feature requests maintenance labels Oct 23, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #798 will degrade performances by 52.29%

Comparing hameerabbasi:dtype-refactor (6a14471) with main (0a0802e)

Summary

❌ 2 (👁 2) regressions
✅ 338 untouched benchmarks

Benchmarks breakdown

Benchmark main hameerabbasi:dtype-refactor Change
👁 test_index_fancy[side=100-rank=1-format='coo'] 678.8 µs 1,422.7 µs -52.29%
👁 test_index_slice[side=100-rank=2-format='gcxs'] 2.6 ms 3.2 ms -16.99%

mtsokol
mtsokol approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@mtsokol mtsokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hameerabbasi hameerabbasi merged commit cc3c8d9 into pydata:main Oct 23, 2024
18 of 19 checks passed
@hameerabbasi hameerabbasi deleted the dtype-refactor branch October 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsokol mtsokol mtsokol approved these changes

Assignees

@hameerabbasi hameerabbasi

Labels
enhancement Indicates new feature requests maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hameerabbasi @mtsokol