Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with actions/download-artifact v4 #9330

Merged

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Dec 26, 2023

Following changes in #9324 due to actions/upload-artifact v4 (which no longer allows multiple jobs to upload to the same .zip artifact), these changes allow the primer workflows to download the individual artifacts before the primer compare command compares them.

@jacobtylerwalls jacobtylerwalls added primer Skip news 🔇 This change does not require a changelog entry labels Dec 26, 2023
@jacobtylerwalls jacobtylerwalls changed the title Add compatibility with actions/upload-artifact v4 Add compatibility with actions/download-artifact v4 Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5b23cd) 95.81% compared to head (16a33ec) 95.81%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9330   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18767    18767           
=======================================
  Hits        17981    17981           
  Misses        786      786           

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Dec 26, 2023

On mobile now, but need to fix a double underscore somewhere hang on done ✅

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the separation in 3 batchs ! I don' t understand github actions well enough to review though.

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Pierre-Sassoulas Pierre-Sassoulas merged commit 76e1b58 into pylint-dev:main Dec 27, 2023
32 checks passed
@jacobtylerwalls jacobtylerwalls deleted the primer-fix-downloads branch December 27, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
primer Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants