Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM when corrected] Enabling parameters in receding horizon #894

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

Kev1CO
Copy link
Collaborator

@Kev1CO Kev1CO commented Oct 7, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@Kev1CO Kev1CO changed the title Enabling parameters in receding horizon [RTR] Enabling parameters in receding horizon Oct 9, 2024
@Kev1CO
Copy link
Collaborator Author

Kev1CO commented Oct 9, 2024

Don't know why the test_run_examples.py craches (tested on local and works).

Test test_continuity_as_objective (further in shard 1) doesn't work in local because of "assert sol.iterations in expected_iterations" I think it comes from # 436 on my laptop @ipuch, 639 on Windows Github CI, 192 on Linux Github CI line 36. I have 762 (on Windows).

Finally can't merge coverage, trying to solve that issue throught pyomeca/cocofest.

@pariterre pariterre changed the title [RTR] Enabling parameters in receding horizon [RTM when corrected] Enabling parameters in receding horizon Oct 29, 2024
@pariterre pariterre merged commit ddd926f into pyomeca:master Nov 8, 2024
13 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants