Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the tests so they work again on CI! #909

Merged
merged 23 commits into from
Jan 31, 2025

Conversation

pariterre
Copy link
Member

@pariterre pariterre commented Jan 27, 2025

  • Made sure drive is in capital letter on Windows for the tests
  • Restore dt dependent tests
  • Find a way to test sensitive tests on Windows -> Evaluate the constraints and the objectives with random values.
  • Restore Acados with parameter.
  • Restore a test_run_examplesin shard1 on windows, works on linux locally but skip on CI online
  • Restore coverage !

This change is Reviewable

@Ipuch Ipuch mentioned this pull request Jan 27, 2025
11 tasks
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.62%. Comparing base (007a4d7) to head (ce87cc9).
Report is 428 commits behind head on master.

Files with missing lines Patch % Lines
bioptim/examples/__main__.py 0.00% 6 Missing ⚠️
bioptim/interfaces/interface_utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   78.51%   77.62%   -0.89%     
==========================================
  Files         141      154      +13     
  Lines       16296    18076    +1780     
==========================================
+ Hits        12794    14032    +1238     
- Misses       3502     4044     +542     
Flag Coverage Δ
unittests 77.62% <75.86%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pariterre pariterre changed the title Made sure drive is in capital letter on Windows for the tests Updated the tests so they work again on CI! Jan 31, 2025
Copy link
Collaborator

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 56 of 57 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pariterre)

@Ipuch Ipuch merged commit fe4d596 into pyomeca:master Jan 31, 2025
22 of 24 checks passed
@pariterre pariterre deleted the test_savior branch January 31, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants