[executorch] Migrate runtime/core to new namespace #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Differential Revision: [D60418073](https://our.internmc.facebook.com/intern/diff/D60418073/) [ghstack-poisoned]
The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names. Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/) [ghstack-poisoned]
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4607
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit b1e29db with merge base 5d151d0 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60428951 |
This was referenced Aug 9, 2024
larryliu0820
approved these changes
Aug 9, 2024
…amespace" Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
…amespace" Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60428951 |
…amespace" Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60428951 |
…amespace" Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally. The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work. Because `EValue` changed namespaces, I also needed to update print_evalue: the `operator<<()` for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own `operator<<` for our types. This is the only scenario where I've seen the namespace aliases break down. Differential Revision: [D60428951](https://our.internmc.facebook.com/intern/diff/D60428951/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60428951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Migrate these headers to the new
::executorch::runtimenamespace. Add temporary aliases from the old::torch::executornamespace so we can migrate users incrementally.The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work.
Because
EValuechanged namespaces, I also needed to update print_evalue: theoperator<<()for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their ownoperator<<for our types. This is the only scenario where I've seen the namespace aliases break down.Differential Revision: D60428951