Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[executorch] Migrate exec_aten utils to new namespace #4609

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[executorch] Migrate exec_aten utils to new namespace #4609

merged 1 commit into from
Aug 20, 2024

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Aug 9, 2024 •
edited
Loading

Migrate these headers to the new ::executorch::runtime namespace. Add temporary aliases from the old ::torch::executor namespace so we can migrate users incrementally.

Differential Revision: D60532173

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4609

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5150119 with merge base 447dc6c (image):

NEW FAILURE - The following job has failed:

  • pull / unittest / macos / macos-job (gh)
    RuntimeError: Failed to compile /var/folders/bm/fnn3xd1d39lcpbxrgwys1c140000gn/T/tmpixzw1ta1/data.json to /var/folders/bm/fnn3xd1d39lcpbxrgwys1c140000gn/T/tmpixzw1ta1/data.pte. Set ET_EXIR_SAVE_FLATC_INPUTS_ON_FAILURE=1 to save input files on failure.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

This was referenced Aug 9, 2024
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

@dbort dbort changed the base branch from gh/dbort/44/base to gh/dbort/43/head August 15, 2024 16:54
Base automatically changed from gh/dbort/43/head to main August 15, 2024 23:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

@dbort @facebook-github-bot
Migrate the rest of //executorch/runtime/... to the new namespace (#4609
5150119 
)

Summary:
Pull Request resolved: #4609

Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally.

ghstack-source-id: 238506975
exported-using-ghexport

Reviewed By: larryliu0820

Differential Revision: D60532173
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60532173

@dbort dbort force-pushed the gh/dbort/44/head branch from 81a41da to 5150119 Compare August 20, 2024 01:03
@facebook-github-bot facebook-github-bot merged commit 6553196 into main Aug 20, 2024
33 of 37 checks passed
@dbort dbort deleted the gh/dbort/44/head branch August 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbort @facebook-github-bot @larryliu0820